Skip to content

small solution to .babelrc in the examples folder #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

small solution to .babelrc in the examples folder #734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3621dc4
remove extra .babelrc
aranajhonny Jan 11, 2017
538d980
fix .babelrc in examples folder
aranajhonny Jan 11, 2017
7af9edd
fix README.md
aranajhonny Jan 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions examples/.babelrc
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions examples/layout-component/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
Download the example (or clone the repo)[https://github.com/zeit/next.js.git]:

```bash
curl https://codeload.github.com/zeit/next.js/tar.gz/master | tar -xz --strip=2 next.js-master/examples/hello-world
cd hello-world
curl https://codeload.github.com/zeit/next.js/tar.gz/master | tar -xz --strip=2 next.js-master/examples/layout-component
cd layout-component
```

Install it and run:
Expand Down
3 changes: 2 additions & 1 deletion examples/layout-component/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@
"start": "next start"
},
"dependencies": {
"next": "*"
"next": "^2.0.0-beta.16"
},
"babel": {},
Copy link
Contributor

@arunoda arunoda Jan 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not good. This works because, we check for .babelrc existence in the app dir. Unless we add next/babel as the preset by default.

We have to fix it. When we do that, it'll break apps using this.

"author": "",
"license": "ISC"
}