Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(turbopack): Evaluate simple numeric addition #70273

Merged
merged 8 commits into from
Sep 26, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use execution test
  • Loading branch information
kdy1 committed Sep 23, 2024
commit beee0ef2da226a0018fee07891df20ce203cec12
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
if (1 +2 !==3) {
require("fail");
}
Copy link
Member

@sokra sokra Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An execution test would be better here

if (1 +2 !==3) {
  require("fail");
}

That's only compiling if correctly evaluated.

Best add it to turbopack/crates/turbopack-tests/tests/execution/turbopack/basic/comptime/input/index.js

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.