Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "chore: bump turbo to 2.0.3" #66775

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Revert "chore: bump turbo to 2.0.3" #66775

merged 1 commit into from
Jun 12, 2024

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jun 12, 2024

Seems the latest turbo version is causing issues with our rust compilation so reverting for now

Reverts #66762

@ijjk ijjk requested review from timeyoutakeit and delbaoliveira and removed request for a team June 12, 2024 01:13
@ijjk ijjk added create-next-app Related to our CLI tool for quickly starting a new Next.js application. created-by: Next.js team PRs by the Next.js team. type: next labels Jun 12, 2024
@socket-security Socket Security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/turbo@1.13.3-canary.2 None +6 126 MB turbobot

🚮 Removed packages: npm/turbo@2.0.3

View full report↗︎

@socket-security Socket Security
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Copyleft License npm/turbo-darwin-arm64@1.13.3-canary.2
Nonpermissive License npm/turbo-darwin-arm64@1.13.3-canary.2
Nonpermissive License npm/turbo-darwin-64@1.13.3-canary.2
Copyleft License npm/turbo-darwin-64@1.13.3-canary.2
Copyleft License npm/turbo@1.13.3-canary.2
Nonpermissive License npm/turbo@1.13.3-canary.2
Copyleft License npm/turbo-linux-64@1.13.3-canary.2
Nonpermissive License npm/turbo-linux-64@1.13.3-canary.2
Copyleft License npm/turbo-linux-arm64@1.13.3-canary.2
Nonpermissive License npm/turbo-linux-arm64@1.13.3-canary.2
Nonpermissive License npm/turbo-windows-64@1.13.3-canary.2
Copyleft License npm/turbo-windows-64@1.13.3-canary.2
Nonpermissive License npm/turbo-windows-arm64@1.13.3-canary.2
Copyleft License npm/turbo-windows-arm64@1.13.3-canary.2

View full report↗︎

Next steps

What do I need to know about license files?

(Experimental) Copyleft license information was found

Determine whether use of copyleft material works for you

What do I need to know about license files?

(Experimental) A license not known to be considered permissive was found

Determine whether use of material not offered under a known permissive license works for you

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/turbo-darwin-arm64@1.13.3-canary.2
  • @SocketSecurity ignore npm/turbo-darwin-64@1.13.3-canary.2
  • @SocketSecurity ignore npm/turbo@1.13.3-canary.2
  • @SocketSecurity ignore npm/turbo-linux-64@1.13.3-canary.2
  • @SocketSecurity ignore npm/turbo-linux-arm64@1.13.3-canary.2
  • @SocketSecurity ignore npm/turbo-windows-64@1.13.3-canary.2
  • @SocketSecurity ignore npm/turbo-windows-arm64@1.13.3-canary.2

@ijjk ijjk merged commit d22da49 into canary Jun 12, 2024
69 of 77 checks passed
@ijjk ijjk deleted the revert-66762-sam/bump-turbo branch June 12, 2024 01:17
@steve-marmalade
Copy link

@ijjk , @ztanner , FWIW I am still seeing next dev --turbo crash with a rust panic. I will open an Issue if I can create a repro (I don't see this on a fresh create next-app), but wanted to put it on your radar.

image

With export RUST_BACKTRACE=1:

thread 'tokio-runtime-worker' panicked at /usr/local/cargo/git/checkouts/turbo-df7a549334890fa5/b37b9c6/crates/turbopack-ecmascript/src/references/external_module.rs:115:9:
not implemented

- A task panicked: not implemented
    at withErrorCause (/home/user/code/web-app/node_modules/.pnpm/next@15.0.0-canary.27_@babel+core@7.24.7_@opentelemetry+api@1.9.0_babel-plugin-react-compiler_gf2txrtm4ledoogihk7jorsbha/node_modules/next/dist/build/swc/index.js:423:19)
    at async EndpointImpl.writeToDisk (/home/user/code/web-app/node_modules/.pnpm/next@15.0.0-canary.27_@babel+core@7.24.7_@opentelemetry+api@1.9.0_babel-plugin-react-compiler_gf2txrtm4ledoogihk7jorsbha/node_modules/next/dist/build/swc/index.js:606:20)
    at async handleRouteType (/home/user/code/web-app/node_modules/.pnpm/next@15.0.0-canary.27_@babel+core@7.24.7_@opentelemetry+api@1.9.0_babel-plugin-react-compiler_gf2txrtm4ledoogihk7jorsbha/node_modules/next/dist/server/dev/turbopack-utils.js:381:41)
    at async Object.ensurePage (/home/user/code/web-app/node_modules/.pnpm/next@15.0.0-canary.27_@babel+core@7.24.7_@opentelemetry+api@1.9.0_babel-plugin-react-compiler_gf2txrtm4ledoogihk7jorsbha/node_modules/next/dist/server/dev/hot-reloader-turbopack.js:652:17)
    at async DevBundlerService.ensurePage (/home/user/code/web-app/node_modules/.pnpm/next@15.0.0-canary.27_@babel+core@7.24.7_@opentelemetry+api@1.9.0_babel-plugin-react-compiler_gf2txrtm4ledoogihk7jorsbha/node_modules/next/dist/server/lib/dev-bundler-service.js:18:20)
    at async DevServer.ensurePage (/home/user/code/web-app/node_modules/.pnpm/next@15.0.0-canary.27_@babel+core@7.24.7_@opentelemetry+api@1.9.0_babel-plugin-react-compiler_gf2txrtm4ledoogihk7jorsbha/node_modules/next/dist/server/dev/next-dev-server.js:550:9)
    at async Object.ensure (/home/user/code/web-app/node_modules/.pnpm/next@15.0.0-canary.27_@babel+core@7.24.7_@opentelemetry+api@1.9.0_babel-plugin-react-compiler_gf2txrtm4ledoogihk7jorsbha/node_modules/next/dist/server/dev/next-dev-server.js:169:17)
    at async DevRouteMatcherManager.matchAll (/home/user/code/web-app/node_modules/.pnpm/next@15.0.0-canary.27_@babel+core@7.24.7_@opentelemetry+api@1.9.0_babel-plugin-react-compiler_gf2txrtm4ledoogihk7jorsbha/node_modules/next/dist/server/route-matcher-managers/dev-route-matcher-manager.js:96:13)
    at async DevRouteMatcherManager.match (/home/user/code/web-app/node_modules/.pnpm/next@15.0.0-canary.27_@babel+core@7.24.7_@opentelemetry+api@1.9.0_babel-plugin-react-compiler_gf2txrtm4ledoogihk7jorsbha/node_modules/next/dist/server/route-matcher-managers/default-route-matcher-manager.js:155:26)
    at async NextNodeServer.handleCatchallRenderRequest (/home/user/code/web-app/node_modules/.pnpm/next@15.0.0-canary.27_@babel+core@7.24.7_@opentelemetry+api@1.9.0_babel-plugin-react-compiler_gf2txrtm4ledoogihk7jorsbha/node_modules/next/dist/server/next-server.js:229:31)
    at async DevServer.handleRequestImpl (/home/user/code/web-app/node_modules/.pnpm/next@15.0.0-canary.27_@babel+core@7.24.7_@opentelemetry+api@1.9.0_babel-plugin-react-compiler_gf2txrtm4ledoogihk7jorsbha/node_modules/next/dist/server/base-server.js:797:17)
    at async /home/user/code/web-app/node_modules/.pnpm/next@15.0.0-canary.27_@babel+core@7.24.7_@opentelemetry+api@1.9.0_babel-plugin-react-compiler_gf2txrtm4ledoogihk7jorsbha/node_modules/next/dist/server/dev/next-dev-server.js:339:20
    at async Span.traceAsyncFn (/home/user/code/web-app/node_modules/.pnpm/next@15.0.0-canary.27_@babel+core@7.24.7_@opentelemetry+api@1.9.0_babel-plugin-react-compiler_gf2txrtm4ledoogihk7jorsbha/node_modules/next/dist/trace/trace.js:157:20)
    at async DevServer.handleRequest (/home/user/code/web-app/node_modules/.pnpm/next@15.0.0-canary.27_@babel+core@7.24.7_@opentelemetry+api@1.9.0_babel-plugin-react-compiler_gf2txrtm4ledoogihk7jorsbha/node_modules/next/dist/server/dev/next-dev-server.js:336:24)
    at async invokeRender (/home/user/code/web-app/node_modules/.pnpm/next@15.0.0-canary.27_@babel+core@7.24.7_@opentelemetry+api@1.9.0_babel-plugin-react-compiler_gf2txrtm4ledoogihk7jorsbha/node_modules/next/dist/server/lib/router-server.js:175:21)
    at async handleRequest (/home/user/code/web-app/node_modules/.pnpm/next@15.0.0-canary.27_@babel+core@7.24.7_@opentelemetry+api@1.9.0_babel-plugin-react-compiler_gf2txrtm4ledoogihk7jorsbha/node_modules/next/dist/server/lib/router-server.js:354:24)
    at async requestHandlerImpl (/home/user/code/web-app/node_modules/.pnpm/next@15.0.0-canary.27_@babel+core@7.24.7_@opentelemetry+api@1.9.0_babel-plugin-react-compiler_gf2txrtm4ledoogihk7jorsbha/node_modules/next/dist/server/lib/router-server.js:378:13)
    at async Server.requestListener (/home/user/code/web-app/node_modules/.pnpm/next@15.0.0-canary.27_@babel+core@7.24.7_@opentelemetry+api@1.9.0_babel-plugin-react-compiler_gf2txrtm4ledoogihk7jorsbha/node_modules/next/dist/server/lib/start-server.js:142:13) {
  [cause]: [Error: Failed to write app endpoint /page

@samcx samcx mentioned this pull request Jun 12, 2024
Merged
samcx added a commit that referenced this pull request Jun 12, 2024
@samcx
chore: bump turbo to 2.0.3 (#66784)
e296846 
## Why?

This pull request bumps turborepo from 1.13.3-canary.2 to
[2.0.3](https://github.com/vercel/turbo/releases/tag/v2.0.3) across
multiple GitHub workflows and configuration files.

Re-attempting after we
[reverted](#66775).
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ztanner ztanner ztanner approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

@feedthejim feedthejim Awaiting requested review from feedthejim

@wyattjoh wyattjoh Awaiting requested review from wyattjoh

@timeyoutakeit timeyoutakeit Awaiting requested review from timeyoutakeit timeyoutakeit was automatically assigned from vercel/devex

@delbaoliveira delbaoliveira Awaiting requested review from delbaoliveira delbaoliveira was automatically assigned from vercel/devex

Assignees
No one assigned
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application. created-by: Next.js team PRs by the Next.js team. locked type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ijjk @steve-marmalade @ztanner