fix(fetch-cache): add check for updated tags when checking same cache key #63547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samcx
requested review from
feedthejim,
huozhi,
shuding,
timneutkens,
wyattjoh and
ztanner
as code owners
Member
Stats from current PRDefault Build (Increase detected
|
| vercel/next.js canary | samcx/next.js sam/fix-fetch-cache-tags | Change | |
|---|---|---|---|
| buildDuration | 14.1s | 14s | N/A |
| buildDurationCached | 7.6s | 6.4s | N/A |
| nodeModulesSize | 199 MB | 199 MB | |
| nextStartRea..uration (ms) | 402ms | 403ms | N/A |
Client Bundles (main, webpack)
| vercel/next.js canary | samcx/next.js sam/fix-fetch-cache-tags | Change | |
|---|---|---|---|
| 2453-HASH.js gzip | 31.4 kB | 31.4 kB | N/A |
| 3304.HASH.js gzip | 181 B | 181 B | ✓ |
| 3f784ff6-HASH.js gzip | 53.7 kB | 53.7 kB | ✓ |
| 8299-HASH.js gzip | 5.05 kB | 5.05 kB | N/A |
| framework-HASH.js gzip | 45.2 kB | 45.2 kB | ✓ |
| main-app-HASH.js gzip | 242 B | 239 B | N/A |
| main-HASH.js gzip | 32.2 kB | 32.2 kB | N/A |
| webpack-HASH.js gzip | 1.68 kB | 1.68 kB | N/A |
| Overall change | 99 kB | 99 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | samcx/next.js sam/fix-fetch-cache-tags | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | samcx/next.js sam/fix-fetch-cache-tags | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 196 B | 197 B | N/A |
| _error-HASH.js gzip | 184 B | 184 B | ✓ |
| amp-HASH.js gzip | 505 B | 505 B | ✓ |
| css-HASH.js gzip | 324 B | 325 B | N/A |
| dynamic-HASH.js gzip | 2.5 kB | 2.5 kB | N/A |
| edge-ssr-HASH.js gzip | 258 B | 258 B | ✓ |
| head-HASH.js gzip | 352 B | 352 B | ✓ |
| hooks-HASH.js gzip | 370 B | 371 B | N/A |
| image-HASH.js gzip | 4.22 kB | 4.22 kB | N/A |
| index-HASH.js gzip | 259 B | 259 B | ✓ |
| link-HASH.js gzip | 2.67 kB | 2.67 kB | N/A |
| routerDirect..HASH.js gzip | 314 B | 312 B | N/A |
| script-HASH.js gzip | 386 B | 386 B | ✓ |
| withRouter-HASH.js gzip | 309 B | 309 B | ✓ |
| 1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
| Overall change | 2.36 kB | 2.36 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | samcx/next.js sam/fix-fetch-cache-tags | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 483 B | 485 B | N/A |
| Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | samcx/next.js sam/fix-fetch-cache-tags | Change | |
|---|---|---|---|
| index.html gzip | 529 B | 529 B | ✓ |
| link.html gzip | 542 B | 541 B | N/A |
| withRouter.html gzip | 524 B | 523 B | N/A |
| Overall change | 529 B | 529 B | ✓ |
Edge SSR bundle Size Overall increase ⚠️
| vercel/next.js canary | samcx/next.js sam/fix-fetch-cache-tags | Change | |
|---|---|---|---|
| edge-ssr.js gzip | 95.4 kB | 95.5 kB | |
| page.js gzip | 3.06 kB | 3.06 kB | N/A |
| Overall change | 95.4 kB | 95.5 kB |
Middleware size
| vercel/next.js canary | samcx/next.js sam/fix-fetch-cache-tags | Change | |
|---|---|---|---|
| middleware-b..fest.js gzip | 623 B | 625 B | N/A |
| middleware-r..fest.js gzip | 151 B | 151 B | ✓ |
| middleware.js gzip | 25.5 kB | 25.5 kB | N/A |
| edge-runtime..pack.js gzip | 839 B | 839 B | ✓ |
| Overall change | 990 B | 990 B | ✓ |
Next Runtimes Overall increase ⚠️
| vercel/next.js canary | samcx/next.js sam/fix-fetch-cache-tags | Change | |
|---|---|---|---|
| app-page-exp...dev.js gzip | 170 kB | 170 kB | ✓ |
| app-page-exp..prod.js gzip | 97.3 kB | 97.3 kB | ✓ |
| app-page-tur..prod.js gzip | 99.1 kB | 99.1 kB | ✓ |
| app-page-tur..prod.js gzip | 93.3 kB | 93.3 kB | ✓ |
| app-page.run...dev.js gzip | 144 kB | 144 kB | ✓ |
| app-page.run..prod.js gzip | 91.8 kB | 91.8 kB | ✓ |
| app-route-ex...dev.js gzip | 21.4 kB | 21.4 kB | ✓ |
| app-route-ex..prod.js gzip | 15.1 kB | 15.1 kB | ✓ |
| app-route-tu..prod.js gzip | 15.1 kB | 15.1 kB | ✓ |
| app-route-tu..prod.js gzip | 14.9 kB | 14.9 kB | ✓ |
| app-route.ru...dev.js gzip | 21.1 kB | 21.1 kB | ✓ |
| app-route.ru..prod.js gzip | 14.9 kB | 14.9 kB | ✓ |
| pages-api-tu..prod.js gzip | 9.55 kB | 9.55 kB | ✓ |
| pages-api.ru...dev.js gzip | 9.82 kB | 9.82 kB | ✓ |
| pages-api.ru..prod.js gzip | 9.55 kB | 9.55 kB | ✓ |
| pages-turbo...prod.js gzip | 22.5 kB | 22.5 kB | ✓ |
| pages.runtim...dev.js gzip | 23.1 kB | 23.1 kB | ✓ |
| pages.runtim..prod.js gzip | 22.4 kB | 22.4 kB | ✓ |
| server.runti..prod.js gzip | 51.1 kB | 51.3 kB | |
| Overall change | 947 kB | 947 kB |
build cache
| vercel/next.js canary | samcx/next.js sam/fix-fetch-cache-tags | Change | |
|---|---|---|---|
| 0.pack gzip | 1.58 MB | 1.58 MB | N/A |
| index.pack gzip | 107 kB | 106 kB | N/A |
| Overall change | 0 B | 0 B | ✓ |
Diff details
Diff for middleware.js
Diff too large to display
Diff for edge-ssr.js
Diff too large to display
Diff for server.runtime.prod.js
Diff too large to display
ijjk
reviewed
Mar 21, 2024
ijjk
reviewed
Mar 22, 2024
ijjk
reviewed
Mar 22, 2024
ijjk
reviewed
Mar 22, 2024
Member
ijjk
left a comment
ijjk
left a comment
There was a problem hiding this comment.
Lets also add this specific fetch/tag case to https://github.com/vercel/next.js/blob/canary/test/e2e/app-dir/app-static/app-static.test.ts
Ethan-Arrowood
approved these changes
Mar 25, 2024
Contributor
Ethan-Arrowood
left a comment
Ethan-Arrowood
left a comment
There was a problem hiding this comment.
looking good. I only have some code style changes, but otherwise this LGTM
Co-authored-by: Ethan Arrowood <ethan@arrowood.dev>
Member
Tests Passed |
ijjk
reviewed
Mar 27, 2024
Member
ijjk
left a comment
ijjk
left a comment
There was a problem hiding this comment.
Changs looks good just need test case before 🚢
ijjk
reviewed
Apr 5, 2024
Ethan-Arrowood
approved these changes
Apr 9, 2024
ijjk
approved these changes
Apr 9, 2024
samcx
added a commit
that referenced
this pull request
Apr 22, 2024
…4799) ## Why? This PR fixes the fetch cache, which currently is not using the fetch cache when it exists (the tags were not getting set properly), and tags have not updated. (Before) https://github.com/vercel/next.js/assets/28912696/74d8f592-0698-4ae4-be4b-30cffb1ffe11 (After) https://github.com/vercel/next.js/assets/28912696/af12b13a-46c6-41c3-9ac3-20e1ec44a865 - #64786 - #63547 Closes NEXT-3173
huozhi
pushed a commit
that referenced
this pull request
Apr 23, 2024
…4799) This PR fixes the fetch cache, which currently is not using the fetch cache when it exists (the tags were not getting set properly), and tags have not updated. (Before) https://github.com/vercel/next.js/assets/28912696/74d8f592-0698-4ae4-be4b-30cffb1ffe11 (After) https://github.com/vercel/next.js/assets/28912696/af12b13a-46c6-41c3-9ac3-20e1ec44a865 - #64786 - #63547 Closes NEXT-3173
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
When we fetch the same cache key (URL) but add an additional tag, the revalidation does not re-fetch correctly (the bug just uses in-memory cache again) when deployed.