Move next/head to Typescript #6131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "git add" | ||
| ], | ||
| "*.tsx": [ | ||
| "tslint -c tslint.json 'packages/**/*.ts' --fix", |
There was a problem hiding this comment.
Shouldn't this be "tslint -c tslint.json 'packages/**/*.tsx' --fix"?
Member
Author
There was a problem hiding this comment.
@damianfrizzi actually it shouldn't have the pages/**/*.ts as lint-staged adds the file to be linted automatically to the command (so that it only runs on the changed file) could you create a PR? 💯
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves a bunch of inconsistencies in handling React elements too.