Drop assetSizePlugin #6122
Merged
Drop assetSizePlugin #6122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 25, 2019
timneutkens
pushed a commit
to vercel/next-plugins
that referenced
this pull request
Jan 25, 2019
Since it's been removed from next (vercel/next.js#6122), I think it makes sense to add next-size here as a community plugin. I'll add a warning to the readme about the memory usage implications and I'll experiment some solutions to solve it in the community plugin itself, so next is safe 👌 some ideas : - just showing the actual size and estimating the gzipped size (empirically) - reading file on fs and calculating gzipped size (with a limit of nb of files)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6121
We can bring back a simplified version of this feature in
build/index.tsthat only shows the list of pages.