-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated props.url
in readme
#4952
Replace deprecated props.url
in readme
#4952
Conversation
props.url
apiprops.url
api in readme
props.url
api in readmeprops.url
in readme
Following #4952 I found two examples with the deprecated`props.url` : - `with-ioc` - `with-next-routes`
This has been deprecated for ages (Since 2.0 was released or so). In general, I would recommend using |
Ok, I'll remove the note and I'll update the examples in the Readme accordingly 👍 |
readme.md
Outdated
@@ -708,9 +704,9 @@ Most prefetching needs are addressed by `<Link />`, but we also expose an impera | |||
```jsx | |||
import Router from 'next/router' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets change this to use withRouter
instead 👍
I still feel like the Router API is a bit hidden in the part about "Intercepting I think it would be good to move it to "Imperatively" just above, or even to move it to "withRouter", since it's the recommended way of using the router 😄 |
Following #4950
Fix #4716
I'm not sure to understand this part, though :
Is there a difference between :
and
?