test(integration): fix skip retry count logic #45930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwonoj
requested review from
timneutkens,
ijjk,
shuding,
huozhi and
feedthejim
as code owners
ijjk
reviewed
Feb 15, 2023
| @@ -8,6 +8,7 @@ import { getParserOptions } from './options' | |||
| import { eventSwcLoadFailure } from '../../telemetry/events/swc-load-failure' | |||
| import { patchIncorrectLockfile } from '../../lib/patch-incorrect-lockfile' | |||
| import { downloadWasmSwc } from '../../lib/download-wasm-swc' | |||
| import { spawn } from 'child_process' | |||
There was a problem hiding this comment.
Why did we switch to spawn from cross-spawn? Also would be nice to keep the require to when it's actually needed.
There was a problem hiding this comment.
I was wondering if https://vercel.slack.com/archives/C04KC8A53T7/p1676439048600469 issue is related with non-native spawn, jest hangs on somewhere and cause sigterm for some tests. I don't honestly have concrete proof, more of trial-and-error to see if it makes a difference or not though.
ijjk
approved these changes
Feb 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is improved followup for #45914, I realized I applied retry count logic only for the teardown, not for the actual execution. PR changes whole retrycount if predicate matches, also changes minor ergonomics for the turbopack output with custom binary.
Bug
fixes #numbercontributing.mdFeature
fixes #numbercontributing.mdDocumentation / Examples
pnpm build && pnpm lint