Skip to content

Fix next/server being required during build #39310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 4, 2022
Merged

Fix next/server being required during build #39310

merged 1 commit into from
Aug 4, 2022

Conversation

@ijjk
Copy link
Member

@ijjk ijjk commented Aug 4, 2022

This ensures we gracefully handle URLPattern not being available when next/server is required e.g. during a build when analyzing pages.

19:17:10.114 | info  - Collecting page data...
19:17:10.114 | ReferenceError: URLPattern is not defined
19:17:10.114 | at Object.<anonymous> (/vercel/path0/node_modules/next/server.js:11:15)

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Aug 4, 2022
@ijjk ijjk marked this pull request as ready for review August 4, 2022 01:18
@ijjk ijjk merged commit de41597 into vercel:canary Aug 4, 2022
@ijjk ijjk deleted the fix/next-server-non-edge branch August 4, 2022 01:18
@snyk-bot snyk-bot mentioned this pull request Aug 26, 2022
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ijjk