Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip warnings for Image not rendered to the dom #32049

Merged
merged 2 commits into from
Dec 3, 2021
Merged

Skip warnings for Image not rendered to the dom #32049

merged 2 commits into from
Dec 3, 2021

Conversation

wnr
Copy link
Contributor

@wnr wnr commented Dec 2, 2021

Some libraries, like react-slick, render their content to a detached element before attaching it to the dom. If the content of such libraries is Image components, they will report warnings because the display/position properties are undefined. This PR squelch the warnings for such cases.

Some libraries, like react-slick, render their content to a detached element before attaching it to the dom. If the content of such libraries is Image components, they will report warnings because the display/position properties are undefined. This PR squelch the warnings for such cases.
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if existing tests pass 👍

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Dec 2, 2021

Failing test suites

Commit: e8ac720

test/integration/image-component/base-path/test/static.test.js

  • Static Image Component Tests for basePath > dev mode > Should allow an image with a static src to omit height and width
  • Static Image Component Tests for basePath > dev mode > Should use immutable cache-control header for static import
  • Static Image Component Tests for basePath > dev mode > Should automatically provide an image height and width
  • Static Image Component Tests for basePath > dev mode > Should allow provided width and height to override intrinsic
  • Static Image Component Tests for basePath > dev mode > Should add a blur placeholder to statically imported jpg
  • Static Image Component Tests for basePath > dev mode > Should add a blur placeholder to statically imported png
Expand output

● Static Image Component Tests for basePath › dev mode › Should allow an image with a static src to omit height and width

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:36535/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:90:23

● Static Image Component Tests for basePath › dev mode › Should use immutable cache-control header for static import

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:36535/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:90:23

● Static Image Component Tests for basePath › dev mode › Should automatically provide an image height and width

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:36535/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:90:23

● Static Image Component Tests for basePath › dev mode › Should allow provided width and height to override intrinsic

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:36535/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:90:23

● Static Image Component Tests for basePath › dev mode › Should add a blur placeholder to statically imported jpg

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:36535/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:90:23

● Static Image Component Tests for basePath › dev mode › Should add a blur placeholder to statically imported png

page.goto: Timeout 30000ms exceeded.
=========================== logs ===========================
navigating to "http://localhost:36535/docs/static-img", waiting until "load"
============================================================

  106 |               .evaluate(`console.log('received ws message ${frame.payload}')`)
  107 |               .catch(() => {})
> 108 |           }
      |            ^
  109 |         }
  110 |       })
  111 |     })

  at Playwright.loadPage (lib/browsers/playwright.ts:108:20)
  at Object.webdriver [as default] (lib/next-webdriver.ts:59:5)
  at integration/image-component/base-path/test/static.test.js:90:23

@ijjk
Copy link
Member

ijjk commented Dec 2, 2021

Note above test failures are unrelated and are being investigated^

@wnr
Copy link
Contributor Author

wnr commented Dec 2, 2021

Okay great 👍

@ijjk
Copy link
Member

ijjk commented Dec 3, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary wnr/next.js patch-1 Change
buildDuration 18s 18.1s ⚠️ +126ms
buildDurationCached 3.3s 3.3s ⚠️ +7ms
nodeModulesSize 347 MB 347 MB ⚠️ +267 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary wnr/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 2.906 2.931 ⚠️ +0.02
/ avg req/sec 860.16 852.96 ⚠️ -7.2
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.33 1.329 0
/error-in-render avg req/sec 1879.04 1880.5 +1.46
Client Bundles (main, webpack, commons)
vercel/next.js canary wnr/next.js patch-1 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.3 kB 72.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary wnr/next.js patch-1 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary wnr/next.js patch-1 Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.49 kB 4.49 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary wnr/next.js patch-1 Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary wnr/next.js patch-1 Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary wnr/next.js patch-1 Change
buildDuration 19.5s 19.5s ⚠️ +11ms
buildDurationCached 3.3s 3.3s -20ms
nodeModulesSize 347 MB 347 MB ⚠️ +267 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary wnr/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 2.907 2.954 ⚠️ +0.05
/ avg req/sec 859.98 846.38 ⚠️ -13.6
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.319 1.31 -0.01
/error-in-render avg req/sec 1895.75 1908.74 +12.99
Client Bundles (main, webpack, commons)
vercel/next.js canary wnr/next.js patch-1 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.6 kB 28.6 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary wnr/next.js patch-1 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary wnr/next.js patch-1 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.53 kB 4.53 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.9 kB 1.9 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary wnr/next.js patch-1 Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary wnr/next.js patch-1 Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: 74b3c86

@kodiakhq kodiakhq bot merged commit 80ec93d into vercel:canary Dec 3, 2021
Kikobeats pushed a commit that referenced this pull request Dec 3, 2021
Some libraries, like react-slick, render their content to a detached element before attaching it to the dom. If the content of such libraries is Image components, they will report warnings because the display/position properties are undefined. This PR squelch the warnings for such cases.
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants