Skip to content

Allow undefined body sent to sendData() #20981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 26, 2021
Merged

Allow undefined body sent to sendData() #20981

merged 6 commits into from
Jan 26, 2021

Conversation

@0xroko
Copy link
Contributor

@0xroko 0xroko commented Jan 11, 2021

Using res.json(undefined); in an API route would cause TypeError: argument entity is required since here we are just checking if body is null. But when generating ETag, value of entity must not == null .

Probably a fix of this

@0xroko 0xroko changed the title Check if body (in sendData() - next-server/server/api-utils.ts) is either null or undefined - since undefined causes TypeError: argument entity is required (ETag) Check if body (in sendData() - next-server/server/api-utils.ts) is either null or undefined - since undefined causes TypeError: argument entity is required (ETag) Jan 11, 2021
@ijjk
Copy link
Member

ijjk commented Jan 11, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary rokobekavac0/next.js canary Change
buildDuration 10.5s 10.4s -135ms
nodeModulesSize 80.8 MB 80.8 MB ⚠️ +64 B
Page Load Tests Overall increase ✓
vercel/next.js canary rokobekavac0/next.js canary Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.126 2.059 -0.07
/ avg req/sec 1176.19 1214.36 +38.17
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.36 1.321 -0.04
/error-in-render avg req/sec 1838.1 1893.02 +54.92
Client Bundles (main, webpack, commons)
vercel/next.js canary rokobekavac0/next.js canary Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-9769710..cf61.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary rokobekavac0/next.js canary Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary rokobekavac0/next.js canary Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary rokobekavac0/next.js canary Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary rokobekavac0/next.js canary Change
index.html gzip 615 B 615 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary rokobekavac0/next.js canary Change
buildDuration 13s 12.5s -465ms
nodeModulesSize 80.8 MB 80.8 MB ⚠️ +64 B
Client Bundles (main, webpack, commons)
vercel/next.js canary rokobekavac0/next.js canary Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-9769710..cf61.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary rokobekavac0/next.js canary Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary rokobekavac0/next.js canary Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary rokobekavac0/next.js canary Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary rokobekavac0/next.js canary Change
_error.js 1 MB 1 MB ⚠️ +18 B
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ⚠️ +18 B
link.js 1.06 MB 1.06 MB ⚠️ +18 B
routerDirect.js 1.05 MB 1.05 MB ⚠️ +18 B
withRouter.js 1.05 MB 1.05 MB ⚠️ +18 B
Overall change 5.18 MB 5.18 MB ⚠️ +90 B
Commit: a8277e9

Timer
Timer requested changes Jan 14, 2021
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test for this please?

@ijjk
Copy link
Member

ijjk commented Jan 15, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary rokobekavac0/next.js canary Change
buildDuration 11.2s 11.4s ⚠️ +243ms
nodeModulesSize 77.5 MB 77.5 MB ⚠️ +64 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary rokobekavac0/next.js canary Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.289 2.322 ⚠️ +0.03
/ avg req/sec 1092.2 1076.69 ⚠️ -15.51
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.587 1.632 ⚠️ +0.04
/error-in-render avg req/sec 1575.09 1531.89 ⚠️ -43.2
Client Bundles (main, webpack, commons)
vercel/next.js canary rokobekavac0/next.js canary Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-b70be25..6967.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary rokobekavac0/next.js canary Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary rokobekavac0/next.js canary Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary rokobekavac0/next.js canary Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary rokobekavac0/next.js canary Change
index.html gzip 613 B 613 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary rokobekavac0/next.js canary Change
buildDuration 13.5s 12.8s -685ms
nodeModulesSize 77.5 MB 77.5 MB ⚠️ +64 B
Client Bundles (main, webpack, commons)
vercel/next.js canary rokobekavac0/next.js canary Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-b70be25..6967.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary rokobekavac0/next.js canary Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary rokobekavac0/next.js canary Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary rokobekavac0/next.js canary Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary rokobekavac0/next.js canary Change
_error.js 1 MB 1 MB ⚠️ +18 B
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ⚠️ +18 B
link.js 1.06 MB 1.06 MB ⚠️ +18 B
routerDirect.js 1.05 MB 1.05 MB ⚠️ +18 B
withRouter.js 1.05 MB 1.05 MB ⚠️ +18 B
Overall change 5.18 MB 5.18 MB ⚠️ +90 B
Commit: b0d3291

timneutkens
timneutkens approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, just checked and res.json(undefined) is supported in express so we can mirror that.

@ijjk
Copy link
Member

ijjk commented Jan 25, 2021 •
edited
Loading

Failing test suites

Commit: 30c5cf0

test/integration/dist-dir/test/index.test.js

  • distDir > should handle null/undefined distDir
Expand output

● distDir › should handle null/undefined distDir

expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: 88

  63 |     await fs.writeFile(nextConfig, origNextConfig)
  64 | 
> 65 |     expect(stderr.length).toBe(0)
     |                           ^
  66 |   })
  67 | })
  68 | 

  at Object.<anonymous> (integration/dist-dir/test/index.test.js:65:27)

test/integration/cli/test/index.test.js

  • CLI Usage > build > should warn when unknown argument provided
Expand output

● CLI Usage › build › should warn when unknown argument provided

expect(received).toEqual(expected) // deep equality

- Expected  - 0
+ Received  + 2

+ Browserslist: caniuse-lite is outdated. Please run:
+ npx browserslist@latest --update-db
  Unknown or unexpected option: --random
  ↵

  79 |         stderr: true,
  80 |       })
> 81 |       expect(stderr).toEqual('Unknown or unexpected option: --random\n')
     |                      ^
  82 |     })
  83 |     test('should not throw UnhandledPromiseRejectionWarning', async () => {
  84 |       const { stderr } = await runNextCommand(['build', '--random'], {

  at Object.<anonymous> (integration/cli/test/index.test.js:81:22)

test/integration/production-build-dir/test/index.test.js

  • Production Custom Build Directory > With basic usage > should render the page
Expand output

● Production Custom Build Directory › With basic usage › should render the page

expect(received).toBe(expected) // Object.is equality

Expected: ""
Received: "Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db
"

  20 |         stderr: true,
  21 |       })
> 22 |       expect(result.stderr).toBe('')
     |                             ^
  23 | 
  24 |       const app = nextServer({
  25 |         dir: join(__dirname, '../build'),

  at Object.<anonymous> (integration/production-build-dir/test/index.test.js:22:29)

@ijjk
Copy link
Member

ijjk commented Jan 25, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary rokobekavac0/next.js canary Change
buildDuration 10.6s 10.6s -16ms
nodeModulesSize 73.3 MB 73.3 MB ⚠️ +64 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary rokobekavac0/next.js canary Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.168 2.168 ✓
/ avg req/sec 1153.28 1153.23 ⚠️ -0.05
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.316 1.348 ⚠️ +0.03
/error-in-render avg req/sec 1900.21 1854.28 ⚠️ -45.93
Client Bundles (main, webpack, commons)
vercel/next.js canary rokobekavac0/next.js canary Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary rokobekavac0/next.js canary Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary rokobekavac0/next.js canary Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary rokobekavac0/next.js canary Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary rokobekavac0/next.js canary Change
index.html gzip 614 B 614 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary rokobekavac0/next.js canary Change
buildDuration 12.4s 12.4s -16ms
nodeModulesSize 73.3 MB 73.3 MB ⚠️ +64 B
Client Bundles (main, webpack, commons)
vercel/next.js canary rokobekavac0/next.js canary Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary rokobekavac0/next.js canary Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary rokobekavac0/next.js canary Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary rokobekavac0/next.js canary Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary rokobekavac0/next.js canary Change
_error.js 1 MB 1 MB ⚠️ +18 B
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ⚠️ +18 B
link.js 1.06 MB 1.06 MB ⚠️ +18 B
routerDirect.js 1.05 MB 1.05 MB ⚠️ +18 B
withRouter.js 1.05 MB 1.05 MB ⚠️ +18 B
Overall change 5.19 MB 5.19 MB ⚠️ +90 B
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary rokobekavac0/next.js canary Change
buildDuration 12.9s 13.2s ⚠️ +325ms
nodeModulesSize 73.3 MB 73.3 MB ⚠️ +64 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary rokobekavac0/next.js canary Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.151 2.176 ⚠️ +0.03
/ avg req/sec 1162.22 1149.09 ⚠️ -13.13
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.363 1.425 ⚠️ +0.06
/error-in-render avg req/sec 1833.96 1754.74 ⚠️ -79.22
Client Bundles (main, webpack, commons)
vercel/next.js canary rokobekavac0/next.js canary Change
597-c48889ef..1870.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary rokobekavac0/next.js canary Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary rokobekavac0/next.js canary Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB ✓
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB ✓
hooks-725de8..0a15.js gzip 904 B 904 B ✓
index-939503..6e1c.js gzip 232 B 232 B ✓
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB ✓
routerDirect..9360.js gzip 308 B 308 B ✓
withRouter-6..44ec.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary rokobekavac0/next.js canary Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary rokobekavac0/next.js canary Change
index.html gzip 588 B 588 B ✓
link.html gzip 593 B 593 B ✓
withRouter.html gzip 581 B 581 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "M-7gC_pRZQ8cI2RKVtuQr",
+        "buildId": "KChMXINM9wUFp5KrEI9ft",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/M-7gC_pRZQ8cI2RKVtuQr/_buildManifest.js"
+      src="/_next/static/KChMXINM9wUFp5KrEI9ft/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/M-7gC_pRZQ8cI2RKVtuQr/_ssgManifest.js"
+      src="/_next/static/KChMXINM9wUFp5KrEI9ft/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "M-7gC_pRZQ8cI2RKVtuQr",
+        "buildId": "KChMXINM9wUFp5KrEI9ft",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/M-7gC_pRZQ8cI2RKVtuQr/_buildManifest.js"
+      src="/_next/static/KChMXINM9wUFp5KrEI9ft/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/M-7gC_pRZQ8cI2RKVtuQr/_ssgManifest.js"
+      src="/_next/static/KChMXINM9wUFp5KrEI9ft/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "M-7gC_pRZQ8cI2RKVtuQr",
+        "buildId": "KChMXINM9wUFp5KrEI9ft",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/M-7gC_pRZQ8cI2RKVtuQr/_buildManifest.js"
+      src="/_next/static/KChMXINM9wUFp5KrEI9ft/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/M-7gC_pRZQ8cI2RKVtuQr/_ssgManifest.js"
+      src="/_next/static/KChMXINM9wUFp5KrEI9ft/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 30c5cf0

@ijjk
Copy link
Member

ijjk commented Jan 25, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary rokobekavac0/next.js canary Change
buildDuration 9.8s 9.9s ⚠️ +126ms
nodeModulesSize 74.9 MB 74.9 MB ⚠️ +64 B
Page Load Tests Overall increase ✓
vercel/next.js canary rokobekavac0/next.js canary Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.044 1.971 -0.07
/ avg req/sec 1222.98 1268.67 +45.69
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.329 1.226 -0.1
/error-in-render avg req/sec 1881.25 2039.64 +158.39
Client Bundles (main, webpack, commons)
vercel/next.js canary rokobekavac0/next.js canary Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary rokobekavac0/next.js canary Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary rokobekavac0/next.js canary Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary rokobekavac0/next.js canary Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary rokobekavac0/next.js canary Change
index.html gzip 614 B 614 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary rokobekavac0/next.js canary Change
buildDuration 11.9s 12.1s ⚠️ +224ms
nodeModulesSize 74.9 MB 74.9 MB ⚠️ +64 B
Client Bundles (main, webpack, commons)
vercel/next.js canary rokobekavac0/next.js canary Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary rokobekavac0/next.js canary Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary rokobekavac0/next.js canary Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary rokobekavac0/next.js canary Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary rokobekavac0/next.js canary Change
_error.js 1 MB 1 MB ⚠️ +18 B
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ⚠️ +18 B
link.js 1.06 MB 1.06 MB ⚠️ +18 B
routerDirect.js 1.05 MB 1.05 MB ⚠️ +18 B
withRouter.js 1.05 MB 1.05 MB ⚠️ +18 B
Overall change 5.19 MB 5.19 MB ⚠️ +90 B
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary rokobekavac0/next.js canary Change
buildDuration 12.3s 12.3s -49ms
nodeModulesSize 74.9 MB 74.9 MB ⚠️ +64 B
Page Load Tests Overall increase ✓
vercel/next.js canary rokobekavac0/next.js canary Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.042 2.011 -0.03
/ avg req/sec 1224.2 1243.09 +18.89
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.486 1.303 -0.18
/error-in-render avg req/sec 1682.27 1918.18 +235.91
Client Bundles (main, webpack, commons)
vercel/next.js canary rokobekavac0/next.js canary Change
597-c48889ef..1870.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary rokobekavac0/next.js canary Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary rokobekavac0/next.js canary Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB ✓
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB ✓
hooks-725de8..0a15.js gzip 904 B 904 B ✓
index-939503..6e1c.js gzip 232 B 232 B ✓
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB ✓
routerDirect..9360.js gzip 308 B 308 B ✓
withRouter-6..44ec.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary rokobekavac0/next.js canary Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary rokobekavac0/next.js canary Change
index.html gzip 588 B 588 B ✓
link.html gzip 593 B 593 B ✓
withRouter.html gzip 581 B 581 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "m6FNixeXA-ZwEZjGYbd3Q",
+        "buildId": "OCqQ0TTA2Di03eLof8-mU",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/m6FNixeXA-ZwEZjGYbd3Q/_buildManifest.js"
+      src="/_next/static/OCqQ0TTA2Di03eLof8-mU/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/m6FNixeXA-ZwEZjGYbd3Q/_ssgManifest.js"
+      src="/_next/static/OCqQ0TTA2Di03eLof8-mU/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "m6FNixeXA-ZwEZjGYbd3Q",
+        "buildId": "OCqQ0TTA2Di03eLof8-mU",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/m6FNixeXA-ZwEZjGYbd3Q/_buildManifest.js"
+      src="/_next/static/OCqQ0TTA2Di03eLof8-mU/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/m6FNixeXA-ZwEZjGYbd3Q/_ssgManifest.js"
+      src="/_next/static/OCqQ0TTA2Di03eLof8-mU/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "m6FNixeXA-ZwEZjGYbd3Q",
+        "buildId": "OCqQ0TTA2Di03eLof8-mU",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/m6FNixeXA-ZwEZjGYbd3Q/_buildManifest.js"
+      src="/_next/static/OCqQ0TTA2Di03eLof8-mU/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/m6FNixeXA-ZwEZjGYbd3Q/_ssgManifest.js"
+      src="/_next/static/OCqQ0TTA2Di03eLof8-mU/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 2adcc59

@ijjk
Copy link
Member

ijjk commented Jan 25, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary rokobekavac0/next.js canary Change
buildDuration 10.4s 10.2s -186ms
nodeModulesSize 74.9 MB 74.9 MB ⚠️ +64 B
Page Load Tests Overall increase ✓
vercel/next.js canary rokobekavac0/next.js canary Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.099 1.999 -0.1
/ avg req/sec 1191.14 1250.51 +59.37
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.3 1.273 -0.03
/error-in-render avg req/sec 1922.52 1964.62 +42.1
Client Bundles (main, webpack, commons)
vercel/next.js canary rokobekavac0/next.js canary Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary rokobekavac0/next.js canary Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary rokobekavac0/next.js canary Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary rokobekavac0/next.js canary Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary rokobekavac0/next.js canary Change
index.html gzip 614 B 614 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary rokobekavac0/next.js canary Change
buildDuration 12.1s 12.3s ⚠️ +201ms
nodeModulesSize 74.9 MB 74.9 MB ⚠️ +64 B
Client Bundles (main, webpack, commons)
vercel/next.js canary rokobekavac0/next.js canary Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary rokobekavac0/next.js canary Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary rokobekavac0/next.js canary Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary rokobekavac0/next.js canary Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary rokobekavac0/next.js canary Change
_error.js 1 MB 1 MB ⚠️ +18 B
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ⚠️ +18 B
link.js 1.06 MB 1.06 MB ⚠️ +18 B
routerDirect.js 1.05 MB 1.05 MB ⚠️ +18 B
withRouter.js 1.05 MB 1.05 MB ⚠️ +18 B
Overall change 5.19 MB 5.19 MB ⚠️ +90 B
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary rokobekavac0/next.js canary Change
buildDuration 12.5s 12.4s -28ms
nodeModulesSize 74.9 MB 74.9 MB ⚠️ +64 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary rokobekavac0/next.js canary Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.99 2.034 ⚠️ +0.04
/ avg req/sec 1256.57 1229.32 ⚠️ -27.25
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.24 1.285 ⚠️ +0.04
/error-in-render avg req/sec 2016.47 1945.05 ⚠️ -71.42
Client Bundles (main, webpack, commons)
vercel/next.js canary rokobekavac0/next.js canary Change
597-c48889ef..1870.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary rokobekavac0/next.js canary Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary rokobekavac0/next.js canary Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB ✓
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB ✓
hooks-725de8..0a15.js gzip 904 B 904 B ✓
index-939503..6e1c.js gzip 232 B 232 B ✓
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB ✓
routerDirect..9360.js gzip 308 B 308 B ✓
withRouter-6..44ec.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary rokobekavac0/next.js canary Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary rokobekavac0/next.js canary Change
index.html gzip 588 B 588 B ✓
link.html gzip 593 B 593 B ✓
withRouter.html gzip 581 B 581 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "GCWv-vizpcdDjoPikLWA1",
+        "buildId": "PNiL10Whxo0GBQMZr2NXP",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/GCWv-vizpcdDjoPikLWA1/_buildManifest.js"
+      src="/_next/static/PNiL10Whxo0GBQMZr2NXP/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/GCWv-vizpcdDjoPikLWA1/_ssgManifest.js"
+      src="/_next/static/PNiL10Whxo0GBQMZr2NXP/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "GCWv-vizpcdDjoPikLWA1",
+        "buildId": "PNiL10Whxo0GBQMZr2NXP",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/GCWv-vizpcdDjoPikLWA1/_buildManifest.js"
+      src="/_next/static/PNiL10Whxo0GBQMZr2NXP/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/GCWv-vizpcdDjoPikLWA1/_ssgManifest.js"
+      src="/_next/static/PNiL10Whxo0GBQMZr2NXP/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "GCWv-vizpcdDjoPikLWA1",
+        "buildId": "PNiL10Whxo0GBQMZr2NXP",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/GCWv-vizpcdDjoPikLWA1/_buildManifest.js"
+      src="/_next/static/PNiL10Whxo0GBQMZr2NXP/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/GCWv-vizpcdDjoPikLWA1/_ssgManifest.js"
+      src="/_next/static/PNiL10Whxo0GBQMZr2NXP/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 87675e5

@ijjk
Copy link
Member

ijjk commented Jan 25, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary rokobekavac0/next.js canary Change
buildDuration 10.2s 10.1s -117ms
nodeModulesSize 74.9 MB 74.9 MB ⚠️ +64 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary rokobekavac0/next.js canary Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.047 1.994 -0.05
/ avg req/sec 1221.29 1253.76 +32.47
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.273 1.295 ⚠️ +0.02
/error-in-render avg req/sec 1963.88 1930.94 ⚠️ -32.94
Client Bundles (main, webpack, commons)
vercel/next.js canary rokobekavac0/next.js canary Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary rokobekavac0/next.js canary Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary rokobekavac0/next.js canary Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary rokobekavac0/next.js canary Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary rokobekavac0/next.js canary Change
index.html gzip 614 B 614 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary rokobekavac0/next.js canary Change
buildDuration 12.3s 11.8s -533ms
nodeModulesSize 74.9 MB 74.9 MB ⚠️ +64 B
Client Bundles (main, webpack, commons)
vercel/next.js canary rokobekavac0/next.js canary Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary rokobekavac0/next.js canary Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary rokobekavac0/next.js canary Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary rokobekavac0/next.js canary Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary rokobekavac0/next.js canary Change
_error.js 1 MB 1 MB ⚠️ +18 B
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ⚠️ +18 B
link.js 1.06 MB 1.06 MB ⚠️ +18 B
routerDirect.js 1.05 MB 1.05 MB ⚠️ +18 B
withRouter.js 1.05 MB 1.05 MB ⚠️ +18 B
Overall change 5.19 MB 5.19 MB ⚠️ +90 B
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary rokobekavac0/next.js canary Change
buildDuration 12.2s 12.6s ⚠️ +379ms
nodeModulesSize 74.9 MB 74.9 MB ⚠️ +64 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary rokobekavac0/next.js canary Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.021 2.038 ⚠️ +0.02
/ avg req/sec 1236.89 1226.59 ⚠️ -10.3
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.241 1.309 ⚠️ +0.07
/error-in-render avg req/sec 2013.95 1909.87 ⚠️ -104.08
Client Bundles (main, webpack, commons)
vercel/next.js canary rokobekavac0/next.js canary Change
597-c48889ef..1870.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary rokobekavac0/next.js canary Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary rokobekavac0/next.js canary Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB ✓
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB ✓
hooks-725de8..0a15.js gzip 904 B 904 B ✓
index-939503..6e1c.js gzip 232 B 232 B ✓
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB ✓
routerDirect..9360.js gzip 308 B 308 B ✓
withRouter-6..44ec.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary rokobekavac0/next.js canary Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary rokobekavac0/next.js canary Change
index.html gzip 587 B 587 B ✓
link.html gzip 591 B 591 B ✓
withRouter.html gzip 580 B 580 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "-PgAg30VBDUYu0Jk9Qjxv",
+        "buildId": "PdC_c3aHnsvqAhMXWkokw",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/-PgAg30VBDUYu0Jk9Qjxv/_buildManifest.js"
+      src="/_next/static/PdC_c3aHnsvqAhMXWkokw/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/-PgAg30VBDUYu0Jk9Qjxv/_ssgManifest.js"
+      src="/_next/static/PdC_c3aHnsvqAhMXWkokw/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "-PgAg30VBDUYu0Jk9Qjxv",
+        "buildId": "PdC_c3aHnsvqAhMXWkokw",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/-PgAg30VBDUYu0Jk9Qjxv/_buildManifest.js"
+      src="/_next/static/PdC_c3aHnsvqAhMXWkokw/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/-PgAg30VBDUYu0Jk9Qjxv/_ssgManifest.js"
+      src="/_next/static/PdC_c3aHnsvqAhMXWkokw/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "-PgAg30VBDUYu0Jk9Qjxv",
+        "buildId": "PdC_c3aHnsvqAhMXWkokw",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/-PgAg30VBDUYu0Jk9Qjxv/_buildManifest.js"
+      src="/_next/static/PdC_c3aHnsvqAhMXWkokw/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/-PgAg30VBDUYu0Jk9Qjxv/_ssgManifest.js"
+      src="/_next/static/PdC_c3aHnsvqAhMXWkokw/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 61a4cb9

@Timer Timer changed the title Check if body (in sendData() - next-server/server/api-utils.ts) is either null or undefined - since undefined causes TypeError: argument entity is required (ETag) Allow undefined body sent to sendData() Jan 26, 2021
@Timer Timer merged commit 004ad62 into vercel:canary Jan 26, 2021
This was referenced Jan 29, 2021
Open
Open
Open
Open
Open
Open
This was referenced Aug 3, 2021
Open
Open
Open
Open
Open
Open
Open
This was referenced Aug 31, 2021
Open
Open
Open
Open
Open
Open
Open
This was referenced Sep 15, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 9, 2021
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Dec 16, 2021
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Timer Timer Timer approved these changes

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

Assignees

No one assigned

Labels

type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@0xroko @ijjk @Timer @timneutkens