Skip to content

Fix linting errors in standard 9.0 #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2017
Merged

Fix linting errors in standard 9.0 #1333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74f2d59
Fix linting errors in standard 9.0
timweprovide Mar 2, 2017
01375f0
Update lockfile
timweprovide Mar 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions examples/with-custom-babel-config/pages/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,13 @@ export default class MyLuckNo extends React.Component {
// using babel-preset-stage-0
const message = do {
if (randomNo < 30) {
// eslint-disable-next-line no-unused-expressions
'Do not give up. Try again.'
} else if (randomNo < 60) {
// eslint-disable-next-line no-unused-expressions
'You are a lucky guy'
} else {
// eslint-disable-next-line no-unused-expressions
Copy link
Member Author

@timneutkens timneutkens Mar 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stage-0 feature is used. So we have to disable style checking for that.

'You are soooo lucky!'
}
}
Expand Down
6 changes: 3 additions & 3 deletions server/on-demand-entry-handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ import { parse } from 'url'
import resolvePath from './resolve'
import touch from 'touch'

const ADDED = Symbol()
const BUILDING = Symbol()
const BUILT = Symbol()
const ADDED = Symbol('added')
const BUILDING = Symbol('building')
const BUILT = Symbol('built')
Copy link
Member Author

@timneutkens timneutkens Mar 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a description for debugging purposes. See https://developer.mozilla.org/nl/docs/Web/JavaScript/Reference/Global_Objects/Symbol


export default function onDemandEntryHandler (devMiddleware, compiler, {
dir,
Expand Down
Loading