Skip to content

Conversation

@lfades
Copy link
Member

@lfades lfades commented Mar 31, 2020

Updated the example to use unstated-next instead of unstated and to not use the state in the server.

@lfades lfades requested a review from Timer as a code owner March 31, 2020 22:58
@ijjk
Copy link
Member

ijjk commented Mar 31, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary lfades/next.js example/update-unstated Change
buildDuration 9.9s 9.8s -97ms
nodeModulesSize 47.7 MB 47.7 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary lfades/next.js example/update-unstated Change
main-HASH.js gzip 6.25 kB 6.25 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..c6c1.js gzip 10.1 kB 10.1 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 56.3 kB 56.3 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary lfades/next.js example/update-unstated Change
main-HASH.module.js gzip 4.78 kB 4.78 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.4 kB 51.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary lfades/next.js example/update-unstated Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary lfades/next.js example/update-unstated Change
_app.js gzip 1.24 kB 1.24 kB
_error.js gzip 3.15 kB 3.15 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 2.03 kB 2.03 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.86 kB 7.86 kB
Client Pages Modern
zeit/next.js canary lfades/next.js example/update-unstated Change
_app.module.js gzip 594 B 594 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.28 kB 5.28 kB
Client Build Manifests
zeit/next.js canary lfades/next.js example/update-unstated Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary lfades/next.js example/update-unstated Change
index.html gzip 919 B 919 B
link.html gzip 927 B 927 B
withRouter.html gzip 917 B 917 B
Overall change 2.76 kB 2.76 kB

Serverless Mode (Increase detected ⚠️)
General
zeit/next.js canary lfades/next.js example/update-unstated Change
buildDuration 10.3s 10.2s -122ms
nodeModulesSize 47.7 MB 47.7 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary lfades/next.js example/update-unstated Change
main-HASH.js gzip 6.25 kB 6.25 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..c6c1.js gzip 10.1 kB 10.1 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 56.3 kB 56.3 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary lfades/next.js example/update-unstated Change
main-HASH.module.js gzip 4.78 kB 4.78 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.71 kB 6.71 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.4 kB 51.4 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary lfades/next.js example/update-unstated Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary lfades/next.js example/update-unstated Change
_app.js gzip 1.24 kB 1.24 kB
_error.js gzip 3.15 kB 3.15 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 2.03 kB 2.03 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.86 kB 7.86 kB
Client Pages Modern
zeit/next.js canary lfades/next.js example/update-unstated Change
_app.module.js gzip 594 B 594 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.28 kB 5.28 kB
Client Build Manifests
zeit/next.js canary lfades/next.js example/update-unstated Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles Overall increase ⚠️
zeit/next.js canary lfades/next.js example/update-unstated Change
_error.js gzip 232 kB 232 kB ⚠️ +234 B
404.html gzip 1.33 kB 1.33 kB
hooks.html gzip 960 B 960 B
index.js gzip 233 kB 232 kB -134 B
link.js gzip 242 kB 243 kB ⚠️ +293 B
routerDirect.js gzip 241 kB 241 kB ⚠️ +105 B
withRouter.js gzip 240 kB 240 kB -10 B
Overall change 1.19 MB 1.19 MB ⚠️ +488 B

@timneutkens timneutkens merged commit 1992e2a into vercel:canary Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants