next build fails on importing a packaging via its conditional export
#45452
Labels
Comments
shuding
added a commit
that referenced
this issue
Feb 15, 2023
#45670) ## Bug The `next build` command is silently overriding the user's tsconfig when it shouldn't be; this results in mismatched behavior between `tsc --noEmit` and `yarn build` and user confusion. For example, a configuration option like `"moduleResolution": "nodenext"`, which is preserved and respected by `next dev`, will be silently overridden to `"moduleResolution": "node"` during `next build`. This change: - Fixes #38854 - (probably fixes) #45452 (I have not verified) - (probably fixes) #41189 (I have not verified) ## Details Next has a concept of both _defaults_ and _permitted options_ when modifying/validating the user's tsconfig. The user's config is only modified if it does not match the _permitted options_. This means that if the user has specified a permitted value like `"moduleResolution": "nodenext"`, it will not be overwritten in the user's config file. However, there was some logic in `runTypeCheck.ts` that did not adequately capture this nuance – instead, it spread all of the defaults into the tsconfig it was building before running typecheck, which meant that if a user had specified an option that was _permitted_ but _non-default_, it would be overwritten, silently, during `yarn build` only. Because Next is already (1) rewriting the TSconfig in `writeConfigurationDefaults` when the user's config doesn't line up with what we're expecting and (2) verifying the user's TSConfig remains correct (in `verifyTypeScriptSetup`) during a `next build`, I believe that it is safe to remove this config-steamrolling behavior. ## Documentation / Examples I believe this is strictly a bugfix; it updates the behavior of `next build` to conform to the same configuration behavior exhibited by `tsc --noEmit` and `next dev`. Since this is already the user expectation, it should not require documentation changes. --------- Co-authored-by: Shu Ding <g@shud.in> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Verify canary release
Provide environment information
Which area(s) of Next.js are affected? (leave empty if unsure)
TypeScript
Link to the code that reproduces this issue
https://stackblitz.com/edit/vercel-next-js-fkhtk7?file=pages/index.tsx
To Reproduce
next devand see it succeedstsc --noEmitand see it succeedsnext buildand see it fails withType error: Cannot find module '...' or its corresponding type declarations.Describe the Bug
This is probably a perfect clone of #43698 , however I think the issue is NOT on Typescript side.
The main difference with the other issue is that running
tsc --noEmitworks perfectly, while usingmoduleResolution: node16. It (correctly) fails while usingmoduleResolution: node, since exports only work with node16/nodenext.next build, however, always fails.I saw #44177 merged in the latest canary, but while
devworks perfectly (and I'm able to use the components),buildcompiles correctly but fails in type checking. Maybe something else is missing?Expected Behavior
The build should work
Which browser are you using? (if relevant)
No response
How are you deploying your application? (if relevant)
No response
The text was updated successfully, but these errors were encountered: