Replies: 30 comments 8 replies
-
Legit request, had to implement biome in my turborepo but still had to let next lint run during linting to keep doctoring functions. Would be nice to be able to chose |
Beta Was this translation helpful? Give feedback.
-
This should get more attention. Biome is really becoming a way more performant replacement for the legacy prettier/eslint toolchain. |
Beta Was this translation helpful? Give feedback.
-
Is this a WIP or already supported? |
Beta Was this translation helpful? Give feedback.
-
Easy +1. |
Beta Was this translation helpful? Give feedback.
-
This really needs to happen. Nextjs used to feel like it was the future, now it seems to be in a bit of a mire:
Genuinely starting to ask the question is Nextjs really a good choice now? |
Beta Was this translation helpful? Give feedback.
-
Would love to see more progress on this. Frustrating to see eslint issues during deployment, when it isn't part of my tool chain. |
Beta Was this translation helpful? Give feedback.
-
Please stop commenting with |
Beta Was this translation helpful? Give feedback.
-
Hello, we were directed to post to GitHub by Vercel support. We had some questions relevant to this discussion. We have been using Questions we believe that are relevant to this discussion as it pertains to potential design flaws of
|
Beta Was this translation helpful? Give feedback.
-
+1 on this! |
Beta Was this translation helpful? Give feedback.
-
This is a necessity from now on.... |
Beta Was this translation helpful? Give feedback.
-
@leerob answered my question about this on X:
|
Beta Was this translation helpful? Give feedback.
-
+1 On this to support own lint packages into Next JS |
Beta Was this translation helpful? Give feedback.
-
Another +1. Just migrated to biome and it's so much faster, and didn't realize NextJS was still going to require it's own linting. 😬 |
Beta Was this translation helpful? Give feedback.
-
Just wanted to point out that since Biome does not currently support custom rules, there is not a clear path to feature parity using biome as an alternative to the next eslint plugin. Until biome supports custom rules or the necessary rules are implemented into core biome, switching to biome as a linter in particular would definitely necessitate sacrificing some of the current features of the eslint plugin. This is obviously not necessarily relevant for other linting tools, but particular to Biome. That being said, disentangling "doctoring" from linting seems like an obvious step forward. Also please stop +1 posting. |
Beta Was this translation helpful? Give feedback.
-
Goals
next lint
and move it to its own independent command (e.g.next doctor
)next lint
Non-Goals
Background
The case against eslint and prettier
Eslint is deprecating formatting rules and community momentum for formatting looks set to move from prettier to Biome. Thus, the current "format with prettier, lint with eslint" setup (which has always pain-points due to mutually exclusive rules and setting up two different tools) is looking less attractive in the long term than simply "format and lint with Biome"..
Users can't bring their own linter
Another discussion has raised the case for documenting how to integrate Biome, but this isn't merely a matter of documentation, as I'll explain below.
As of today, starter templates (at least for Turbo) typically configure projects to lint using
next lint
. This prevents users from bringing their own linting setups as linting is dependent on the Next.js CLI.Unfortunately, we can't simply ditch
next lint
, as it does more than just linting. It does some significant (and valuable) doctoring, too.next lint
, as of v14.0.4, does the following:--ext
and a Next-appropriate--cache-location
.typescript
,@types/react
, and@types/node
tsconfig.json
:["next-env.d.ts", "**/*.ts", "**/*.tsx", ".next/types/**/*.ts"]
in yourincludes
array{ "name": "next" }
in yourplugins
arraynode_modules
next-env.d.ts
has been generatedsetting(impossible because the value is hard-coded).opts.lintDuringBuild: true
opts.lintDuringBuild: false
(which is the default) and selectingnull
when prompted which config to start with next timenext lint
is run. However, this is interactive, so unless we can find a way to pipe the necessary input into it via the shell, I am not sure how we can automate this.Proposal
next lint
and allow users to use their preferred linter command directly.next doctor
command that users could optionally run as part of their linting step.Beta Was this translation helpful? Give feedback.
All reactions