Skip to content

Commit fa8ab99

Browse files
authored
Fix with-firebase-hosting running locally (#21971)
1 parent 74e0c6d commit fa8ab99

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

examples/with-firebase-hosting/firebaseFunctions.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,10 @@ const { join } = require('path')
22
const { https } = require('firebase-functions')
33
const { default: next } = require('next')
44

5-
const isDev = process.env.NODE_ENV !== 'production'
65
const nextjsDistDir = join('src', require('./src/next.config.js').distDir)
76

87
const nextjsServer = next({
9-
dev: isDev,
8+
dev: false,
109
conf: {
1110
distDir: nextjsDistDir,
1211
},

examples/with-firebase-hosting/package.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,15 @@
1313
"logs": "firebase functions:log"
1414
},
1515
"dependencies": {
16-
"firebase-admin": "^8.9.0",
17-
"firebase-functions": "^3.3.0",
18-
"next": "^9.3.4",
19-
"react": "^16.13.1",
20-
"react-dom": "^16.13.1"
16+
"firebase-admin": "^9.4.2",
17+
"firebase-functions": "^3.13.1",
18+
"next": "latest",
19+
"react": "^17.0.1",
20+
"react-dom": "^17.0.1"
2121
},
2222
"devDependencies": {
23-
"firebase-functions-test": "^0.1.6",
24-
"firebase-tools": "^8.6.0"
23+
"firebase-functions-test": "^0.2.3",
24+
"firebase-tools": "^9.3.0"
2525
},
2626
"license": "MIT"
2727
}

0 commit comments

Comments
 (0)