Skip to content

Commit ef2bbfe

Browse files
arunodarauchg
authored andcommitted
Add default entries to main.js (#1343)
So, we don't need to add them to individual pages. This also fix the issue where, error pages doesn't ping the server.
1 parent 62fcb2b commit ef2bbfe

File tree

2 files changed

+13
-10
lines changed

2 files changed

+13
-10
lines changed

server/build/webpack.js

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,22 @@ const relativeResolve = rootModuleRelativePath(require)
2828
export default async function createCompiler (dir, { dev = false, quiet = false, buildDir } = {}) {
2929
dir = resolve(dir)
3030
const config = getConfig(dir)
31-
const defaultEntries = dev
32-
? [join(__dirname, '..', '..', 'client/webpack-hot-middleware-client')] : []
31+
const defaultEntries = dev ? [
32+
join(__dirname, '..', '..', 'client', 'webpack-hot-middleware-client'),
33+
join(__dirname, '..', '..', 'client', 'on-demand-entries-client')
34+
] : []
3335
const mainJS = dev
3436
? require.resolve('../../client/next-dev') : require.resolve('../../client/next')
3537

3638
let minChunks
3739

3840
const entry = async () => {
39-
const entries = { 'main.js': mainJS }
41+
const entries = {
42+
'main.js': [
43+
...defaultEntries,
44+
mainJS
45+
]
46+
}
4047

4148
const pages = await glob('pages/**/*.js', { cwd: dir })
4249
const devPages = pages.filter((p) => p === 'pages/_document.js' || p === 'pages/_error.js')
@@ -45,11 +52,11 @@ export default async function createCompiler (dir, { dev = false, quiet = false,
4552
// managing pages.
4653
if (dev) {
4754
for (const p of devPages) {
48-
entries[join('bundles', p)] = [...defaultEntries, `./${p}?entry`]
55+
entries[join('bundles', p)] = `./${p}?entry`
4956
}
5057
} else {
5158
for (const p of pages) {
52-
entries[join('bundles', p)] = [...defaultEntries, `./${p}?entry`]
59+
entries[join('bundles', p)] = `./${p}?entry`
5360
}
5461
}
5562

server/on-demand-entry-handler.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -71,11 +71,7 @@ export default function onDemandEntryHandler (devMiddleware, compiler, {
7171
const pathname = await resolvePath(pagePath)
7272
const name = join('bundles', pathname.substring(dir.length))
7373

74-
const entry = [
75-
join(__dirname, '..', 'client/webpack-hot-middleware-client'),
76-
join(__dirname, '..', 'client', 'on-demand-entries-client'),
77-
`${pathname}?entry`
78-
]
74+
const entry = `${pathname}?entry`
7975

8076
await new Promise((resolve, reject) => {
8177
const entryInfo = entries[page]

0 commit comments

Comments
 (0)