review comments

Author: sokra

turbopack/crates/turbo-tasks-backend/src/backend/mod.rs

@@ -201,12 +201,10 @@ impl TurboTasksBackendInner {
         unsafe { ExecuteContext::new_with_tx(self, tx, turbo_tasks) }
     }
 
-    #[inline]
     fn suspending_requested(&self) -> bool {
         (self.in_progress_operations.load(Ordering::Relaxed) & SNAPSHOT_REQUESTED_BIT) != 0
     }
 
-    #[inline]
     fn operation_suspend_point(&self, suspend: impl FnOnce() -> AnyOperation) {
         #[cold]
         fn operation_suspend_point_cold(

turbopack/crates/turbo-tasks-backend/src/backend/operation/cleanup_old_edges.rs

@@ -82,9 +82,10 @@ impl Operation for CleanupOldEdgesOperation {
                                 for &child_id in children.iter() {
                                     task.remove(&CachedDataItemKey::Child { task: child_id });
                                 }
+                                let remove_children_count = u32::try_from(children.len()).unwrap();
                                 update!(task, ChildrenCount, |count: Option<u32>| {
                                     // If this underflows, we messed up counting somewhere
-                                    let count = count.unwrap_or_default() - children.len() as u32;
+                                    let count = count.unwrap_or_default() - remove_children_count;
                                     (count != 0).then_some(count)
                                 });
                                 if is_aggregating_node(get_aggregation_number(&task)) {