From c7317702567eacd421a369710e264b8f838084a5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=EA=B0=95=EB=8F=99=EC=9C=A4=20=28Donny=29?= Date: Fri, 13 Oct 2023 15:53:23 +0900 Subject: [PATCH] clippy --- packages/next-swc/crates/core/src/cjs_optimizer.rs | 2 +- packages/next-swc/crates/core/src/optimize_server_react.rs | 6 ++---- packages/next-swc/crates/core/src/page_config.rs | 6 +++--- 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/packages/next-swc/crates/core/src/cjs_optimizer.rs b/packages/next-swc/crates/core/src/cjs_optimizer.rs index 7139a63909545..53a0a1b3a5ca0 100644 --- a/packages/next-swc/crates/core/src/cjs_optimizer.rs +++ b/packages/next-swc/crates/core/src/cjs_optimizer.rs @@ -233,7 +233,7 @@ impl VisitMut for CjsOptimizer { self.data.imports.insert( key, ImportRecord { - module_specifier: v.value.clone().into(), + module_specifier: v.value.clone(), }, ); } diff --git a/packages/next-swc/crates/core/src/optimize_server_react.rs b/packages/next-swc/crates/core/src/optimize_server_react.rs index 1d1f662eef65b..df23b16b46cd6 100644 --- a/packages/next-swc/crates/core/src/optimize_server_react.rs +++ b/packages/next-swc/crates/core/src/optimize_server_react.rs @@ -68,7 +68,7 @@ impl Fold for OptimizeServerReact { new_items.push(item.clone().fold_with(self)); if let ModuleItem::ModuleDecl(ModuleDecl::Import(import_decl)) = &item { - if import_decl.src.value.to_string() != "react" { + if import_decl.src.value != "react" { continue; } for specifier in &import_decl.specifiers { @@ -119,9 +119,7 @@ impl Fold for OptimizeServerReact { if &f.to_id() == react_ident { if let MemberProp::Ident(i) = &member.prop { // Remove `React.useEffect` and `React.useLayoutEffect` calls - if i.sym.to_string() == "useEffect" - || i.sym.to_string() == "useLayoutEffect" - { + if i.sym == "useEffect" || i.sym == "useLayoutEffect" { return Expr::Lit(Lit::Null(Null { span: DUMMY_SP })); } } diff --git a/packages/next-swc/crates/core/src/page_config.rs b/packages/next-swc/crates/core/src/page_config.rs index 2cd97f79783bd..495eb0abaff31 100644 --- a/packages/next-swc/crates/core/src/page_config.rs +++ b/packages/next-swc/crates/core/src/page_config.rs @@ -77,7 +77,7 @@ impl Fold for PageConfig { for decl in &var_decl.decls { let mut is_config = false; if let Pat::Ident(ident) = &decl.name { - if &ident.id.sym == CONFIG_KEY { + if ident.id.sym == CONFIG_KEY { is_config = true; } } @@ -151,14 +151,14 @@ impl Fold for PageConfig { match &specifier.exported { Some(ident) => { if let ModuleExportName::Ident(ident) = ident { - if &ident.sym == CONFIG_KEY { + if ident.sym == CONFIG_KEY { self.handle_error("Config cannot be re-exported.", specifier.span) } } } None => { if let ModuleExportName::Ident(ident) = &specifier.orig { - if &ident.sym == CONFIG_KEY { + if ident.sym == CONFIG_KEY { self.handle_error("Config cannot be re-exported.", specifier.span) } }