Skip to content

Commit 9afa1a8

Browse files
committed
fix problem with HMR when middleware and page reference the same node_module
1 parent 791c356 commit 9afa1a8

File tree

5 files changed

+9
-12
lines changed

5 files changed

+9
-12
lines changed

packages/next/build/webpack-config.ts

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -959,11 +959,6 @@ export default async function getBaseWebpackConfig(
959959
},
960960
}
961961

962-
const nonUserCondition = {
963-
include: /node_modules/,
964-
exclude: babelIncludeRegexes,
965-
}
966-
967962
let webpackConfig: webpack.Configuration = {
968963
parallelism: Number(process.env.NEXT_WEBPACK_PARALLELISM) || undefined,
969964
externals: targetWeb
@@ -1256,13 +1251,6 @@ export default async function getBaseWebpackConfig(
12561251
},
12571252
],
12581253
},
1259-
{
1260-
...nonUserCondition,
1261-
// Make all non-user modules to be compiled in a single layer
1262-
// This avoids compiling them mutliple times and avoids module id changes
1263-
issuerLayer: 'middleware',
1264-
layer: '',
1265-
},
12661254
...(!config.images.disableStaticImages
12671255
? [
12681256
{

test/integration/middleware/hmr/node_modules/shared-package/index.js

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/integration/middleware/hmr/node_modules/shared-package/package.json

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
import { NextResponse } from 'next/server'
2+
import magicValue from 'shared-package'
23

34
export function middleware(request) {
5+
if (magicValue !== 42) throw new Error('shared-package problem')
46
return NextResponse.rewrite(new URL('/about/a', request.url))
57
}

test/integration/middleware/hmr/pages/index.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
import magicValue from 'shared-package'
2+
if (magicValue !== 42) throw new Error('shared-package problem')
3+
14
export default function Home() {
25
return (
36
<div>

0 commit comments

Comments
 (0)