Skip to content

Commit 47d9372

Browse files
committed
avoid storing transient tasks
1 parent bc917da commit 47d9372

File tree

1 file changed

+4
-4
lines changed
  • turbopack/crates/turbo-tasks-backend/src/backend/operation

1 file changed

+4
-4
lines changed

turbopack/crates/turbo-tasks-backend/src/backend/operation/mod.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ impl<'a> TaskGuard<'a> {
144144
}
145145

146146
pub fn add(&mut self, item: CachedDataItem) -> bool {
147-
if !item.is_persistent() {
147+
if self.task_id.is_transient() || !item.is_persistent() {
148148
self.task.add(item)
149149
} else if self.task.add(item.clone()) {
150150
let (key, value) = item.into_key_and_value();
@@ -165,7 +165,7 @@ impl<'a> TaskGuard<'a> {
165165

166166
pub fn insert(&mut self, item: CachedDataItem) -> Option<CachedDataItemValue> {
167167
let (key, value) = item.into_key_and_value();
168-
if !key.is_persistent() {
168+
if self.task_id.is_transient() || !key.is_persistent() {
169169
self.task
170170
.insert(CachedDataItem::from_key_and_value(key, value))
171171
} else if value.is_persistent() {
@@ -209,7 +209,7 @@ impl<'a> TaskGuard<'a> {
209209
key: &CachedDataItemKey,
210210
update: impl FnOnce(Option<CachedDataItemValue>) -> Option<CachedDataItemValue>,
211211
) {
212-
if !key.is_persistent() {
212+
if self.task_id.is_transient() || !key.is_persistent() {
213213
self.task.update(key, update);
214214
return;
215215
}
@@ -254,7 +254,7 @@ impl<'a> TaskGuard<'a> {
254254
pub fn remove(&mut self, key: &CachedDataItemKey) -> Option<CachedDataItemValue> {
255255
let old_value = self.task.remove(key);
256256
if let Some(value) = old_value {
257-
if key.is_persistent() && value.is_persistent() {
257+
if !self.task_id.is_transient() && key.is_persistent() && value.is_persistent() {
258258
let key = key.clone();
259259
self.task.persistance_state.add_persisting_item();
260260
self.backend

0 commit comments

Comments
 (0)