Only warn on large Shell errors

Author: eps1lon

packages/next/src/server/app-render/app-render.tsx

@@ -193,6 +193,7 @@ import {
   trackPendingModules,
 } from './module-loading/track-module-loading.external'
 import { isUseCacheTimeoutError } from '../use-cache/use-cache-errors'
+import { isReactLargeShellError } from './react-large-shell-error'
 
 export type GetDynamicParamFromSegment = (
   // [slug] / [[slug]] / [...slug]
@@ -2336,6 +2337,12 @@ async function spawnDynamicValidationInDev(
           return digest
         }
 
+        if (isReactLargeShellError(err)) {
+          // TODO: Aggregate
+          console.error(err)
+          return undefined
+        }
+
         if (initialServerPrerenderController.signal.aborted) {
           // The render aborted before this error was handled which indicates
           // the error is caused by unfinished components within the render
@@ -2442,6 +2449,12 @@ async function spawnDynamicValidationInDev(
             return digest
           }
 
+          if (isReactLargeShellError(err)) {
+            // TODO: Aggregate
+            console.error(err)
+            return undefined
+          }
+
           if (initialClientController.signal.aborted) {
             // These are expected errors that might error the prerender. we ignore them.
           } else if (
@@ -2531,6 +2544,12 @@ async function spawnDynamicValidationInDev(
                 return err.digest
               }
 
+              if (isReactLargeShellError(err)) {
+                // TODO: Aggregate
+                console.error(err)
+                return undefined
+              }
+
               return getDigestForWellKnownError(err)
             },
             signal: finalServerController.signal,
@@ -2605,6 +2624,12 @@ async function spawnDynamicValidationInDev(
                   return
                 }
 
+                if (isReactLargeShellError(err)) {
+                  // TODO: Aggregate
+                  console.error(err)
+                  return undefined
+                }
+
                 return getDigestForWellKnownError(err)
               },
               // We don't need bootstrap scripts in this prerender
@@ -2915,6 +2940,12 @@ async function prerenderToStream(
               return digest
             }
 
+            if (isReactLargeShellError(err)) {
+              // TODO: Aggregate
+              console.error(err)
+              return undefined
+            }
+
             if (initialServerPrerenderController.signal.aborted) {
               // The render aborted before this error was handled which indicates
               // the error is caused by unfinished components within the render
@@ -3037,6 +3068,12 @@ async function prerenderToStream(
                 return digest
               }
 
+              if (isReactLargeShellError(err)) {
+                // TODO: Aggregate
+                console.error(err)
+                return undefined
+              }
+
               if (initialClientController.signal.aborted) {
                 // These are expected errors that might error the prerender. we ignore them.
               } else if (

packages/next/src/server/app-render/create-error-handler.tsx

@@ -9,6 +9,7 @@ import { isDynamicServerError } from '../../client/components/hooks-server-conte
 import { isNextRouterError } from '../../client/components/is-next-router-error'
 import { getProperError } from '../../lib/is-error'
 import { createDigestWithErrorCode } from '../../lib/error-telemetry-utils'
+import { isReactLargeShellError } from './react-large-shell-error'
 
 declare global {
   var __next_log_error__: undefined | ((err: unknown) => void)
@@ -62,6 +63,12 @@ export function createFlightReactServerErrorHandler(
       return digest
     }
 
+    if (isReactLargeShellError(thrownValue)) {
+      // TODO: Aggregate
+      console.error(thrownValue)
+      return undefined
+    }
+
     const err = getProperError(thrownValue) as DigestedError
 
     // If the error already has a digest, respect the original digest,
@@ -114,6 +121,12 @@ export function createHTMLReactServerErrorHandler(
       return digest
     }
 
+    if (isReactLargeShellError(thrownValue)) {
+      // TODO: Aggregate
+      console.error(thrownValue)
+      return undefined
+    }
+
     const err = getProperError(thrownValue) as DigestedError
 
     // If the error already has a digest, respect the original digest,
@@ -171,6 +184,12 @@ export function createHTMLErrorHandler(
   onHTMLRenderSSRError: (err: DigestedError, errorInfo?: ErrorInfo) => void
 ): SSRErrorHandler {
   return (thrownValue: unknown, errorInfo?: ErrorInfo) => {
+    if (isReactLargeShellError(thrownValue)) {
+      // TODO: Aggregate
+      console.error(thrownValue)
+      return undefined
+    }
+
     let isSSRError = true
 
     allCapturedErrors.push(thrownValue)

packages/next/src/server/app-render/prospective-render-utils.ts

@@ -1,4 +1,5 @@
 import { getDigestForWellKnownError } from './create-error-handler'
+import { isReactLargeShellError } from './react-large-shell-error'
 
 export function printDebugThrownValueForProspectiveRender(
   thrownValue: unknown,
@@ -9,6 +10,12 @@ export function printDebugThrownValueForProspectiveRender(
     return
   }
 
+  if (isReactLargeShellError(thrownValue)) {
+    // TODO: Aggregate
+    console.error(thrownValue)
+    return undefined
+  }
+
   let message: undefined | string
   if (
     typeof thrownValue === 'object' &&

packages/next/src/server/app-render/react-large-shell-error.ts

@@ -0,0 +1,13 @@
+// TODO: isWellKnownError -> isNextInternalError
+// isReactLargeShellError -> isWarning
+export function isReactLargeShellError(
+  error: unknown
+): error is Error & { digest?: string } {
+  return (
+    typeof error === 'object' &&
+    error !== null &&
+    'message' in error &&
+    typeof error.message === 'string' &&
+    error.message.startsWith('This rendered a large document (>')
+  )
+}

packages/next/src/server/use-cache/use-cache-wrapper.ts

@@ -53,6 +53,7 @@ import type { Params } from '../request/params'
 import React from 'react'
 import { createLazyResult, isResolvedLazyResult } from '../lib/lazy-result'
 import { dynamicAccessAsyncStorage } from '../app-render/dynamic-access-async-storage.external'
+import { isReactLargeShellError } from '../app-render/react-large-shell-error'
 
 type CacheKeyParts =
   | [buildId: string, id: string, args: unknown[]]
@@ -400,6 +401,12 @@ async function generateCacheEntryImpl(
       return digest
     }
 
+    if (isReactLargeShellError(error)) {
+      // TODO: Aggregate
+      console.error(error)
+      return undefined
+    }
+
     if (process.env.NODE_ENV !== 'development') {
       // TODO: For now we're also reporting the error here, because in
       // production, the "Server" environment will only get the obfuscated