From 37ea26bde0ed98e1186f4ef05d2c8f71ddb636e5 Mon Sep 17 00:00:00 2001 From: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com> Date: Mon, 7 Oct 2024 21:03:46 +0200 Subject: [PATCH] Add `require-in-the-middle` to default externals (#70922) Closes PACK-3288 Closes https://github.com/vercel/next.js/issues/70424 Sentry uses `open-telemetry`, which uses `require-in-the-middle` which: - overrides the global `Module.prototype.require`, even when bundled - reads `require.cache` which when bundled is Turbopack's registry (not the outer Node.js one) Because of this, `require-in-the-middle` is broken/results in a broken environment when it's bundled (e.g. via `instrumentation.js`). --- .../05-next-config-js/serverExternalPackages.mdx | 1 + .../04-next-config-js/serverExternalPackages.mdx | 1 + packages/next/src/lib/server-external-packages.json | 1 + 3 files changed, 3 insertions(+) diff --git a/docs/02-app/02-api-reference/05-next-config-js/serverExternalPackages.mdx b/docs/02-app/02-api-reference/05-next-config-js/serverExternalPackages.mdx index bd2d55cc8e6ff..26a408356d0f6 100644 --- a/docs/02-app/02-api-reference/05-next-config-js/serverExternalPackages.mdx +++ b/docs/02-app/02-api-reference/05-next-config-js/serverExternalPackages.mdx @@ -69,6 +69,7 @@ Next.js includes a [short list of popular packages](https://github.com/vercel/ne - `prisma` - `puppeteer-core` - `puppeteer` +- `require-in-the-middle` - `rimraf` - `sharp` - `shiki` diff --git a/docs/03-pages/02-api-reference/04-next-config-js/serverExternalPackages.mdx b/docs/03-pages/02-api-reference/04-next-config-js/serverExternalPackages.mdx index 9902a4c89e444..0097dd9dae69b 100644 --- a/docs/03-pages/02-api-reference/04-next-config-js/serverExternalPackages.mdx +++ b/docs/03-pages/02-api-reference/04-next-config-js/serverExternalPackages.mdx @@ -69,6 +69,7 @@ Next.js includes a [short list of popular packages](https://github.com/vercel/ne - `prisma` - `puppeteer-core` - `puppeteer` +- `require-in-the-middle` - `rimraf` - `sharp` - `shiki` diff --git a/packages/next/src/lib/server-external-packages.json b/packages/next/src/lib/server-external-packages.json index cfa1f13a1fba3..c7fff52a5cfec 100644 --- a/packages/next/src/lib/server-external-packages.json +++ b/packages/next/src/lib/server-external-packages.json @@ -50,6 +50,7 @@ "prisma", "puppeteer", "puppeteer-core", + "require-in-the-middle", "rimraf", "sharp", "shiki",