Skip to content

Commit 357500c

Browse files
committed
Disable for deploy tests for now
1 parent f941f0d commit 357500c

File tree

1 file changed

+47
-40
lines changed

1 file changed

+47
-40
lines changed

test/e2e/app-dir/use-cache/use-cache.test.ts

Lines changed: 47 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -390,48 +390,55 @@ describe('use-cache', () => {
390390
})
391391
})
392392

393-
it('should not use stale caches in server actions that have revalidated', async () => {
394-
const browser = await next.browser('/revalidate-and-use')
395-
const useCacheValue1 = await browser.elementById('use-cache-value-1').text()
396-
const useCacheValue2 = await browser.elementById('use-cache-value-2').text()
397-
const fetchedValue = await browser.elementById('fetched-value').text()
398-
399-
expect(useCacheValue1).toEqual(useCacheValue2)
400-
401-
await browser.elementById('revalidate-tag').click()
402-
await browser.waitForElementByCss('#revalidate-tag:enabled')
403-
404-
const useCacheValueBeforeRevalidation = await browser
405-
.elementById('use-cache-value-1')
406-
.text()
407-
const useCacheValueAfterRevalidation = await browser
408-
.elementById('use-cache-value-2')
409-
.text()
410-
const newFetchedValue = await browser.elementById('fetched-value').text()
411-
412-
expect(useCacheValueBeforeRevalidation).toBe(useCacheValue1)
413-
expect(useCacheValueBeforeRevalidation).toBe(useCacheValue2)
414-
expect(useCacheValueBeforeRevalidation).not.toBe(
415-
useCacheValueAfterRevalidation
416-
)
417-
expect(newFetchedValue).not.toBe(fetchedValue)
393+
// TODO: Enable for deploy tests when upstream changes have been rolled out.
394+
if (!isNextDeploy) {
395+
it('should not use stale caches in server actions that have revalidated', async () => {
396+
const browser = await next.browser('/revalidate-and-use')
397+
const useCacheValue1 = await browser
398+
.elementById('use-cache-value-1')
399+
.text()
400+
const useCacheValue2 = await browser
401+
.elementById('use-cache-value-2')
402+
.text()
403+
const fetchedValue = await browser.elementById('fetched-value').text()
404+
405+
expect(useCacheValue1).toEqual(useCacheValue2)
406+
407+
await browser.elementById('revalidate-tag').click()
408+
await browser.waitForElementByCss('#revalidate-tag:enabled')
409+
410+
const useCacheValueBeforeRevalidation = await browser
411+
.elementById('use-cache-value-1')
412+
.text()
413+
const useCacheValueAfterRevalidation = await browser
414+
.elementById('use-cache-value-2')
415+
.text()
416+
const newFetchedValue = await browser.elementById('fetched-value').text()
417+
418+
expect(useCacheValueBeforeRevalidation).toBe(useCacheValue1)
419+
expect(useCacheValueBeforeRevalidation).toBe(useCacheValue2)
420+
expect(useCacheValueBeforeRevalidation).not.toBe(
421+
useCacheValueAfterRevalidation
422+
)
423+
expect(newFetchedValue).not.toBe(fetchedValue)
418424

419-
await browser.elementById('revalidate-path').click()
420-
await browser.waitForElementByCss('#revalidate-path:enabled')
425+
await browser.elementById('revalidate-path').click()
426+
await browser.waitForElementByCss('#revalidate-path:enabled')
421427

422-
expect(await browser.elementById('use-cache-value-1').text()).not.toBe(
423-
useCacheValueBeforeRevalidation
424-
)
425-
expect(await browser.elementById('use-cache-value-2').text()).not.toBe(
426-
useCacheValueAfterRevalidation
427-
)
428-
expect(await browser.elementById('use-cache-value-1').text()).not.toBe(
429-
await browser.elementById('use-cache-value-2').text()
430-
)
431-
expect(await browser.elementById('fetched-value').text()).not.toBe(
432-
newFetchedValue
433-
)
434-
})
428+
expect(await browser.elementById('use-cache-value-1').text()).not.toBe(
429+
useCacheValueBeforeRevalidation
430+
)
431+
expect(await browser.elementById('use-cache-value-2').text()).not.toBe(
432+
useCacheValueAfterRevalidation
433+
)
434+
expect(await browser.elementById('use-cache-value-1').text()).not.toBe(
435+
await browser.elementById('use-cache-value-2').text()
436+
)
437+
expect(await browser.elementById('fetched-value').text()).not.toBe(
438+
newFetchedValue
439+
)
440+
})
441+
}
435442

436443
if (isNextStart) {
437444
it('should prerender fully cacheable pages as static HTML', async () => {

0 commit comments

Comments
 (0)