Skip to content

Commit 3403955

Browse files
authored
[test] Use unique error messages in server-source-maps (#79108)
Allows unambigious assertions on CLI output. Not that interesting for dev but `next build` will have the logs for all pages in all tests. I also made the pages static where possible so that we'll be able to assert on the logged errors during `next build`.
1 parent b08c5a3 commit 3403955

File tree

14 files changed

+125
-131
lines changed

14 files changed

+125
-131
lines changed

test/e2e/app-dir/server-source-maps/fixtures/default/app/bad-sourcemap/page.js

Lines changed: 2 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/e2e/app-dir/server-source-maps/fixtures/default/app/bad-sourcemap/page.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/e2e/app-dir/server-source-maps/fixtures/default/app/rsc-error-log-cause/page.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,9 @@
1-
import { connection } from 'next/server'
2-
31
function logError(cause) {
4-
const error = new Error('Boom', { cause })
2+
const error = new Error('rsc-error-log-cause', { cause })
53
console.error(error)
64
}
75

8-
export default async function Page() {
9-
await connection()
10-
6+
export default function Page() {
117
const error = new Error('Boom')
128
logError(error)
139
return null
Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,10 @@
1-
import { connection } from 'next/server'
2-
31
class UnnamedError extends Error {}
42
class NamedError extends Error {
53
name = 'MyError'
64
}
75

8-
export default async function Page() {
9-
await connection()
10-
11-
console.error(new UnnamedError('Foo'))
12-
console.error(new NamedError('Bar'))
6+
export default function Page() {
7+
console.error(new UnnamedError('rsc-error-log-custom-name-Foo'))
8+
console.error(new NamedError('rsc-error-log-custom-name-Bar'))
139
return null
1410
}

test/e2e/app-dir/server-source-maps/fixtures/default/app/rsc-error-log-ignore-listed/page.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,15 @@
1-
import { connection } from 'next/server'
21
import { runInternal } from 'internal-pkg'
32
import { runInternalSourceMapped } from 'internal-pkg/sourcemapped'
43
import { runInternalIgnored } from 'internal-pkg/ignored'
54
import { runExternal } from 'external-pkg'
65
import { runExternalSourceMapped } from 'external-pkg/sourcemapped'
76

87
function logError() {
9-
const error = new Error('Boom')
8+
const error = new Error('rsc-error-log-ignore-listed')
109
console.error(error)
1110
}
1211

1312
export default async function Page() {
14-
await connection()
15-
1613
runInternal(function runWithInternal() {
1714
runInternalSourceMapped(function runWithInternalSourceMapped() {
1815
runExternal(function runWithExternal() {
Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,11 @@
11
import { someClass } from './styles.module.css'
2-
import { connection } from 'next/server'
32

43
function logError() {
5-
const error = new Error('Boom')
4+
const error = new Error('rsc-error-log')
65
console.error(error)
76
}
87

9-
export default async function Page() {
10-
await connection()
11-
8+
export default function Page() {
129
logError()
1310
return <p className={someClass}>Hello, Dave!</p>
1411
}

test/e2e/app-dir/server-source-maps/fixtures/default/app/ssr-error-log-ignore-listed/page.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { runExternal } from 'external-pkg'
66
import { runExternalSourceMapped } from 'external-pkg/sourcemapped'
77

88
function logError() {
9-
const error = new Error('Boom')
9+
const error = new Error('ssr-error-log-ignore-listed')
1010
console.error(error)
1111
}
1212

test/e2e/app-dir/server-source-maps/fixtures/default/app/ssr-throw/Thrower.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
'use client'
22

33
function throwError() {
4-
throw new Error('Boom')
4+
throw new Error('ssr-throw')
55
}
66

77
export function Thrower() {

test/e2e/app-dir/server-source-maps/fixtures/default/bad-sourcemap/page.js

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,11 @@
22
// Then change the `sources` entry in the sourcemap to `["custom://[badhost]/app/bad-sourcemap/page.js"]`
33
// tsc compile errors can be ignored
44

5-
import { connection } from 'next/server'
6-
75
function logError() {
8-
console.error(new Error('Boom!'))
6+
console.error(new Error('bad-sourcemap'))
97
}
108

11-
export default async function Page() {
12-
await connection()
9+
export default function Page() {
1310
logError()
1411
return <p>Hello, Dave!</p>
1512
}

test/e2e/app-dir/server-source-maps/fixtures/edge/app/rsc-error-log/page.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
function logError() {
2-
console.error(new Error('Boom'))
2+
console.error(new Error('rsc-error-log'))
33
}
44

55
export default function Page() {

0 commit comments

Comments
 (0)