Skip to content

Commit 182ab2e

Browse files
nimit95ijjk
authored andcommitted
Browserstack optimisations (#7201)
* add local identifier to suppoort parallel runs BrowserStack Signed-off-by: Nimit <nimitagg95@gmail.com> * calling driver quit to stop test and then killing binary Signed-off-by: Nimit <nimitagg95@gmail.com> * run lint-fix * standard fixes Signed-off-by: Nimit <nimitagg95@gmail.com>
1 parent f861e0d commit 182ab2e

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

test/jest-environment.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,8 @@ if (isBrowserStack) {
4444
}
4545
const sharedOpts = {
4646
'browserstack.local': true,
47-
'browserstack.video': false
47+
'browserstack.video': false,
48+
'browserstack.localIdentifier': global.browserStackLocal.localIdentifierFlag
4849
}
4950

5051
browserOptions = {

test/jest-global-setup.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@ if (process.env.BROWSERSTACK) {
55
const { Local } = require('browserstack-local')
66
const browserStackLocal = new Local()
77
const localBrowserStackOpts = {
8-
key: process.env.BROWSERSTACK_ACCESS_KEY
8+
key: process.env.BROWSERSTACK_ACCESS_KEY,
9+
localIdentifier: new Date().getTime() // Adding a unique local identifier to run parallel tests on BrowserStack
910
}
1011
global.browserStackLocal = browserStackLocal
1112

test/jest-global-teardown.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@ if (process.env.BROWSERSTACK) {
1111
}
1212

1313
module.exports = async () => {
14-
await globalTeardown()
15-
1614
if (browser) {
1715
// Close all remaining browser windows
1816
try {
@@ -21,7 +19,11 @@ module.exports = async () => {
2119
if (!window) continue
2220
await browser.window(window)
2321
await browser.origClose()
22+
await browser.quit()
23+
await globalTeardown()
2424
}
2525
} catch (_) {}
26+
} else {
27+
await globalTeardown()
2628
}
2729
}

0 commit comments

Comments
 (0)