Fira Code ligatures not showing

[ericmarkmartin]

After updating Hyperterm to 0.8.3 through homebrew cask, the Fira Code font's ligatures don't work, even though the font itself is being used

In the above screenshot, the 0 especially gives away that FiraCode is being used and not Menlo.

Yet as you can see from the arrow function above, the ligatures are not being used.

[0x6c7862]

This CSS will re-enable ligatures:

x-screen x-row { font-variant-ligatures: contextual; }

[wolverian]

FWIW, even if I add the CSS to Hyper's config (the css key), the x-row elements don't get that style. 🤔

[dak0rn]

As suggested in another issue, I added the following to the configuration to make ligatures work. I am using Hasklig instead of Fira Code, though, but I expect the font not to be the issue.

[iamstarkov]

definitely a bug, but also a dup #874

[ericmarkmartin]

Thanks for the replies. Unfortunately I didn't see that issue since because it was marked closed, not a bug, and didn't contain the word Fira.

[mjswensen]

Thanks for the workaround, @0x6c7862 and @dak0rn ! Works great for now.

I didn't see any code in this repo explicitly turning them off so my guess is that a dependency upstream somewhere changed and broke this behavior.

I'd vote for ligatures being enabled by default unless there's a good reason not to. People coming to a terminal based on JS, HTML, and CSS will expect ligatures to work out of the box.

[ccorcos]

Hmm. I wasn't able to get it to work:

[fczuardi]

@ccorcos the relevant lines:

    // font family with optional fallbacks
    fontFamily: '"Fira Code", Menlo, "DejaVu Sans Mono", "Lucida Console", monospace',

and

    // custom css to embed in the terminal window
    termCSS: `
        x-screen x-row {
            font-variant-ligatures: initial;
        }
    `,

[ccorcos]

wait, now its working! :)

[gluons]

Is it posible to add a simple boolean option to trigger this feature?

[thasmo]

enableLigatures pls :D

[matheuss]

It is @gluons