Auto select install command on modal open #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chabou
reviewed
Apr 24, 2018
| <pre | ||
| ref={pre => { | ||
| this.installCode = pre | ||
| }} |
There was a problem hiding this comment.
It will recreate a function at each render.
Maybe better to move this to an onInstallCodeRef() method, binded to this in constructor.
This is obviously not a performance bottleneck 😀
But maybe cleaner.
mischah
added a commit
to mischah/hyper-site
that referenced
this pull request
Apr 25, 2018
* master: Add hyper-savetext to Hyper store (vercel#29) Update readme Fix bug when trying to access props instead of state Add hyper-oceanic-next theme (vercel#44) Auto select install code iwhen InstallModal opens (vercel#38) 1.2.0 Fix install modal Only try to load plugin data from npms where needed Fix content not displaying if npms.io is down # Conflicts: # plugins.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a tiny UX improvement 🍬
You can ⌘ + c immediately after clicking "Install".
I placed
selectTextin thelibdirectory, let me know if that's okay.