Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hyper-savetext to Hyper store #29

Merged
merged 3 commits into from
Apr 25, 2018
Merged

Add hyper-savetext to Hyper store #29

merged 3 commits into from
Apr 25, 2018

Conversation

neil-orans
Copy link
Contributor

This updated pull request has a preview image with 1200x800 dimensions

@neil-orans
Add hyperterm-savetext to Hyper store
f56952f 
This updated pull request has a preview image with 1200x800 dimensions
@timothyis
Copy link
Contributor

Thank you so much for your contribution!

I have a few requests, if possible:

  1. If you could rename your package to hyper-savetext. hyperterm is the old name for Hyper and we can't use or promote that name anymore.
  2. If possible, make your preview image 600x400 pixels with 2x density (so it turns out being 1200x800 pixels). If you need help with this, I'm happy to supply an image with your plugin!
  3. Please make it so your image doesn't have a white background. If the background was transparent or had an image as the background (like from unsplash.com) that would be much better. Again I'm happy to help out there.

@markozxuu
Copy link
Contributor

@neil-orans The link of the image is broken :(

@neil-orans
Copy link
Contributor Author

@mapeso I am aware. I am fixing some issues with the repository and will fix that before I try to get this PR accepted again

@neil-orans
Copy link
Contributor Author

@timothyis I've renamed the package to hyper-savetext, and uploaded a picture that doesn't have a white background, but I'm not sure how to address your second point. The preview image is 1200x800, but I'm not sure how to make it 600x400 with 2x pixel density (I always thought pixel density was decided by the device displaying the image, not by the image itself).

@timothyis
Copy link
Contributor

@neil-orans Could you submit those new changes? Then we'll see 🙏

Also yes, I need to update the wiki on how to create different density screenshots. I'll work on that this week 🙏

@neil-orans
Copy link
Contributor Author

Changes pushed. Thanks @timothyis

@timothyis timothyis changed the title Add hyperterm-savetext to Hyper store Add hyper-savetext to Hyper store Apr 25, 2018
@timothyis timothyis merged commit 318c5b2 into vercel:master Apr 25, 2018
@timothyis
Copy link
Contributor

Thank you!

mischah added a commit to mischah/hyper-site that referenced this pull request Apr 25, 2018
@mischah
Merge branch 'master' into patch-1
f5fe087 
* master:
  Add hyper-savetext to Hyper store (vercel#29)
  Update readme
  Fix bug when trying to access props instead of state
  Add hyper-oceanic-next theme (vercel#44)
  Auto select install code iwhen InstallModal opens (vercel#38)
  1.2.0
  Fix install modal
  Only try to load plugin data from npms where needed
  Fix content not displaying if npms.io is down

# Conflicts:
#	plugins.json
@neil-orans neil-orans deleted the patch-1 branch May 16, 2018 04:06
@neil-orans neil-orans restored the patch-1 branch May 29, 2018 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neil-orans @timothyis @markozxuu