Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shallow routing #27

Merged
merged 3 commits into from
Apr 16, 2018
Merged

Conversation

timneutkens
Copy link
Member

This makes sure Next's Router is used instead of manipulating the history directly.

@timothyis
Copy link
Contributor

Thanks again, this fixes the main issue of not being able to search and click on a plugin after being on a plugin page. Unfortunately, the issue of clicking the back button to go back to the search page still exists although I think I can solve that outside of this PR. 🙏

@timothyis timothyis merged commit 2e857cf into vercel:master Apr 16, 2018
@timneutkens timneutkens deleted the add/shallow-routing branch April 17, 2018 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants