-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CJS files are missing in 1.2.0 #132
Comments
Thanks for the bug report. I've published version 1.2.1 Would you mind trying it @Mause? |
Looks good now, thanks for the quick fix! |
For posterity, would you mind telling me how to reproduce the error? Thanks a million. |
Just updated to |
Thank you @SferaDev. Can you tell us more about your setup, including versions? |
Sure:
Error:
Using Was working fine in 1.2.0 (and versions prior to that), tests stopped passing with automated workflow to update to 1.2.1 |
Thanks for the help @SferaDev. I could reproduce and fix it, by exporting CJS code when running on Node. however it's a bit unfair, since the docs says that we could either use CJS or ESM. I guess it's a nasty combination of jest, ts-node and node. I'm waiting for an approver, and I'll release this. |
I've released 1.2.2, please try and let me know |
It's unclear if this was an intentional change?
You can see the files being missing here: https://app.renovatebot.com/package-diff?name=@vercel%2fanalytics&from=1.1.3&to=1.2.0
They are still referenced in the package.json file as well:
The text was updated successfully, but these errors were encountered: