Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Pundit v2 (and keep Pundit v1 support) #103

Closed
valscion opened this issue Aug 3, 2018 · 2 comments
Closed

Support Pundit v2 (and keep Pundit v1 support) #103

valscion opened this issue Aug 3, 2018 · 2 comments
Labels
good first issue help wanted

Comments

@valscion
Copy link
Member

valscion commented Aug 3, 2018

Hi there, community!

We would like jsonapi-authorization to support Pundit v2 while maintaining support for v1.

This likely means some infrastructure work to test this gem with both versions.

We should use only those Pundit features that are available in both v1 and v2 for now.

This issue is a contribution opportunity for anyone! Please comment below if you'd like to try to tackle this.
@valscion valscion mentioned this issue Aug 3, 2018
Closed
@jpalumickas
Copy link
Contributor

Opened PR #104 for this.

@valscion
Copy link
Member Author

Released support for Pundit v2 via #104 to new beta v1.0.0.beta2 — thanks @jpalumickas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Milestone
No milestone
Development

No branches or pull requests
2 participants
@valscion @jpalumickas