Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script-ability #45

Closed
eikenb opened this issue Jun 22, 2017 · 5 comments
Closed

Script-ability #45

eikenb opened this issue Jun 22, 2017 · 5 comments
Milestone

Comments

@eikenb
Copy link

eikenb commented Jun 22, 2017

Would you consider a pull request that added a way to make the call to aws-adfs non-interactive. I'm thinking a login argument that has it take accept the password from STDIN (like sudo -S) and another that lets you give the username on the command line.

Thought I'd ask to see if you'd be open to a PR before just diving into the code.

Thanks.

@eikenb
Copy link
Author

eikenb commented Jun 22, 2017

I think it might be better to just have the stdin argument that takes a username/password pair. So it is one option and you eliminate weird states like having the password passed in but no username. Either separated by a newline, colon, or something similar.

@venth
Copy link
Owner

venth commented Jun 22, 2017

OK, please create PR. I'll look into it.

@eikenb
Copy link
Author

eikenb commented Jun 22, 2017

Submitted the PR; #48

@venth venth added this to the 0.3.x milestone Jun 24, 2017
@venth
Copy link
Owner

venth commented Jun 24, 2017

PR #48 merged and released with version 0.3.6

@eikenb
Copy link
Author

eikenb commented Jun 24, 2017

Great. Thanks!

@eikenb eikenb closed this as completed Jun 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants