-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(create): Supporting SSL enforced PostgreSQL databases #2905
fix(create): Supporting SSL enforced PostgreSQL databases #2905
Conversation
If a db has mandatory ssl when connecting the current @vendure/create fails. Implemented SSL Option for PostgreSQL Added SSL option to populate function
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for effervescent-donut-4977b2 canceled.
|
Thanks for this PR - it's a good addition. 2 things:
|
Hello!
|
Yeah, the "false" default is good, and yes probably just a note as suggested along the lines of "(only enable if you database provider supports SSL)" will be enough. A further enhancement (which you don't need to add to this PR, but can if you like), would be to detect SSL connection errors during bootstrap of the server, and display an instruction to try again with the SSL option turned on. |
If a db has mandatory ssl when connecting the current @vendure/create fails. Implemented SSL Option for PostgreSQL Added SSL option to populate function Implemented error handling for error 28000 interpreted as SSL error
I have added the error handling and description, now i need to find out on how to change the branch towards which I want to PR against 😄 |
@michaelbromley ah that easy, thanks 😄 I changed it, anything else I need to do? |
Nope, we're all good! Thanks for the contribution. This will be made available in the next minor release (v2.3) |
Description
If a db has mandatory ssl when connecting the current @vendure/create fails.
Implemented SSL Option for PostgreSQL
Added SSL option to populate function
fixes #2904
Breaking changes
No
Checklist
📌 Always:
👍 Most of the time: