Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodemailer caches smtpTransport singleton #3265

Open
mschipperheyn opened this issue Dec 9, 2024 · 0 comments
Open

nodemailer caches smtpTransport singleton #3265

mschipperheyn opened this issue Dec 9, 2024 · 0 comments
Labels
type: bug 🐛 Something isn't working

Comments

@mschipperheyn
Copy link
Collaborator

Describe the bug
the nodemailer implementation stores smtpTransport on the instance. This invalidates the getTransport call if you are in a multivendor scenario and makes it impossible to have vendor specific smtp configurations.

My colleage Ankish identified this issue and is adding a PR for it

To Reproduce
Steps to reproduce the behavior:

  1. Create mutliple channels with their own smtp configs
  2. Select the config on the fly
  3. Only the first used transport gets used

Expected behavior
Transport should be selected on the fly based on configuration settings.

Environment (please complete the following information):

  • @vendure/core version: 3.0.8
  • Nodejs version
  • Database (mysql/postgres etc):
@mschipperheyn mschipperheyn added the type: bug 🐛 Something isn't working label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant