Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendure-v3.04 not switching between dark and light mode #3111

Closed
ashishkpaul opened this issue Oct 6, 2024 · 3 comments
Closed

Vendure-v3.04 not switching between dark and light mode #3111

ashishkpaul opened this issue Oct 6, 2024 · 3 comments
Labels
P3: minor Non-critical, no workarounds exist type: bug 🐛 Something isn't working @vendure/admin-ui
Milestone

Comments

@ashishkpaul
Copy link

Describe the bug
A clear and concise description of what the bug is.
Screenshot_2024-10-06_09-16-16

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Dashboard'
  2. Click on 'Theme'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Environment (please complete the following information):

  • @vendure/core version:
  • Nodejs version
  • Database (mysql/postgres etc):

Additional context
Add any other context about the problem here.

@ashishkpaul ashishkpaul added the type: bug 🐛 Something isn't working label Oct 6, 2024
@michaelbromley michaelbromley added @vendure/admin-ui P3: minor Non-critical, no workarounds exist labels Oct 8, 2024
@michaelbromley michaelbromley moved this to 📅 Planned in Vendure OS Roadmap Oct 8, 2024
@michaelbromley michaelbromley added this to the v3.0.5 milestone Oct 8, 2024
@michaelbromley michaelbromley moved this from 📅 Planned to ♻️ In progress in Vendure OS Roadmap Oct 14, 2024
@roberttolton
Copy link

This still seems broken in 3.0.5?

Fresh install as of the start of October, updated to 3.0.5 today via updating dependencies and npm install.

Zight.Recording.2024-10-31.at.09.41.02.am.mp4

@michaelbromley
Copy link
Member

@roberttolton can you try:

  1. deleting any admin-ui dir created by the compilation process
  2. delete any .angular dir that may exist
  3. delete node_modules & lockfile, reinstall dependencies

and try again and see if that resolves it?

@roberttolton
Copy link

Hi @michaelbromley, thanks for your help.

This morning I installed a fresh 3.0.5 to compare against, and saw that a bunch of the CSS variables were getting overridden. It hit me then that I had began to customise the theme weeks ago before I had to pause work and come back to it now, and completely forgot.

For my custom theme, I'm now making sure it targets a specific mode e.g :root [cds-theme=light] and everything works.

Apologies for wasting your time, I am certainly banging my head on the desk now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3: minor Non-critical, no workarounds exist type: bug 🐛 Something isn't working @vendure/admin-ui
Projects
Archived in project
Development

No branches or pull requests

3 participants