Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot remove coupon after applying in draft order #2969

Closed
Dominic-Preap opened this issue Jul 23, 2024 · 1 comment
Closed

Cannot remove coupon after applying in draft order #2969

Dominic-Preap opened this issue Jul 23, 2024 · 1 comment
Labels
P2: important Critical issue which does not affect majority of users type: bug 🐛 Something isn't working @vendure/admin-ui
Milestone

Comments

@Dominic-Preap
Copy link
Contributor

Describe the bug

We are testing on order UI and found out that when apply coupon in draft order it's working but when we try to remove it, it shows error toast. In the docs, remove coupon code must use string but the coupon code in body is null.

image

To Reproduce
Steps to reproduce the behavior:

  1. Go to promotion, create new promotion with discount % and code ex: 'TEST'
  2. Go to order, create new draft order
  3. Add any new products
  4. Apply coupon code 'TEST'
  5. Then click remove on dropdown select
  6. See error

Expected behavior
It should be able to add and remove coupon in draft order.

Environment (please complete the following information):

  • @vendure/core version: 3.0.0
  • Nodejs version: 20
  • Database (mysql): 8

Additional context
N/A

@Dominic-Preap Dominic-Preap added the type: bug 🐛 Something isn't working label Jul 23, 2024
@ericlou168
Copy link

I faced the same issues

@michaelbromley michaelbromley added @vendure/admin-ui P2: important Critical issue which does not affect majority of users labels Jul 24, 2024
@michaelbromley michaelbromley moved this to 📋 Backlog in Vendure OS Roadmap Jul 24, 2024
@dlhck dlhck added this to the v3.0.4 milestone Sep 27, 2024
@michaelbromley michaelbromley moved this from 💯 Ready to 🚀 Shipped in Vendure OS Roadmap Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2: important Critical issue which does not affect majority of users type: bug 🐛 Something isn't working @vendure/admin-ui
Projects
Archived in project
Development

No branches or pull requests

4 participants