Issue on clean startup (dbempty) and superadminCredentials.identifier with a least one character uppercase

[giosueDelgado]

Describe the bug
When attempting a clean startup with the "dbempty" flag, and having at least one uppercase character in the superadminCredentials.identifier, an issue occurs.

To Reproduce
Steps to reproduce the behavior:

Go to 'the startup configuration file'.
Set the dbempty flag to true.
In the superadminCredentials.identifier, use a string with at least one uppercase character, for example "Admin".
Attempt to start up Vendure.
See error.
Expected behavior
The expected behavior is for Vendure to start up cleanly, regardless of the case of characters in the superadminCredentials.identifier.

Environment (please complete the following information):

@vendure/core version: 2.1.1
Nodejs version: 16.17.0
Database (mysql/postgres etc): postgres

[giosueDelgado]

FYI @LorenzoRottigni

[michaelbromley]

Hi,

What's the dbempty flag you refer to? I'm not sure how to reproduce what you have run into but I just tested with this config:

    authOptions: {
        disableAuth: false,
        tokenMethod: ['bearer', 'cookie'] as const,
        requireVerification: true,
        customPermissions: [],
        cookieOptions: {
            secret: 'abc',
        },
        superadminCredentials: {
            identifier: 'Admin',
            password: 'admin',
        },
    },

and repopulated the server from scratch and was then able to login with the provided superadmin credentials.

[giosueDelgado]

Sorry I be more clear: there isn't a emptydb flag but is to setup an empty database.
Using the version 2.1.1 we were unable to start the database using the string admVendure because the logic was creating the user admvendure (lowercase) so it continue to create user and not find that was existing because not exist in the database with an uppercase..

[michaelbromley]

Thanks for the clarification. Investigation revealed several points that needed fixing in order to support case-sensitive identifiers. This will be fixed in the next patch.