Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The break change for relations of ProductService.findOne() on V2.1 #2443

Closed
tianyingchun opened this issue Oct 12, 2023 · 0 comments
Closed
Assignees
Labels
type: bug 🐛 Something isn't working

Comments

@tianyingchun
Copy link
Contributor

Describe the bug
The productService.findOne() can not correct apply customized relations

To Reproduce
Steps to reproduce the behavior:

image
it seems that there is a break change for productService.findOne()
image
e.g.

const product = await this.productService.findOne(ctx, productId, [
      'variants',
      'variants.facetValues',
    ]);

above code will return property variants as array
after upgrade V2.1 the relations can. not to apply, the variants return null

Expected behavior
Should correct keep custom relations

Environment (please complete the following information):

  • @vendure/core version:2.1
  • Nodejs version: 18
  • Database (mysql/postgres etc):mysql

Additional context
upgrade V2.1 app is break down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants