Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add variant Id in the ProductVariantPriceCalculationArgs object #2398

Closed
ttournie opened this issue Sep 18, 2023 · 1 comment
Closed

Add variant Id in the ProductVariantPriceCalculationArgs object #2398

ttournie opened this issue Sep 18, 2023 · 1 comment
Labels
type: feature ✨

Comments

@ttournie
Copy link
Contributor

Is your feature request related to a problem? Please describe.
in ProductVariantPriceCalculationArgs of ProductVariantPriceCalculationStrategy
we should be able to know for which variant you are calculation the price.

Describe the solution you'd like
Add the variant Id inside the args
@michaelbromley michaelbromley moved this to 📅 Planned in Vendure OS Roadmap Sep 18, 2023
@michaelbromley michaelbromley moved this from 📅 Planned to 📋 Backlog in Vendure OS Roadmap Sep 21, 2023
@michaelbromley michaelbromley moved this from 📋 Backlog to 🏗 In progress in Vendure OS Roadmap Sep 26, 2023
michaelbromley added a commit that referenced this issue Sep 26, 2023
@michaelbromley
feat(core): Pass variant to ProductVariantPriceCalculationStrategy
fee995c 
Closes #2398
@michaelbromley michaelbromley moved this from 🏗 In progress to 🔖 Ready in Vendure OS Roadmap Sep 26, 2023
@michaelbromley
Copy link
Member

Implemented for v2.1

@michaelbromley michaelbromley moved this from 🔖 Ready to ✅ Done in Vendure OS Roadmap Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature ✨
Projects
Vendure OS Roadmap
Status: 🚀 Shipped
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ttournie @michaelbromley