Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Rich HTML editor removes target="_blank" #2281

Closed
martijnvdbrug opened this issue Jul 12, 2023 · 2 comments
Closed

Bug: Rich HTML editor removes target="_blank" #2281

martijnvdbrug opened this issue Jul 12, 2023 · 2 comments
Assignees
Labels
type: bug 🐛 Something isn't working

Comments

@martijnvdbrug
Copy link
Collaborator

Describe the bug
We would like some links in the product descriptions to open in a new tab, but the rich-html-editor removes the tag target="_blank" after we click update (see screenshot).

To Reproduce

  1. Go to a product detail
  2. Create a link via the link button in the toolbar
  3. Click the arrow with "Edit HTML"
  4. In the popup window, add target="_blank" in the anchor tag
  5. Click "update"
  6. Click "Edit HTML" again
  7. The tag has been removed

Expected behavior
I would expect the target="_blank" tag to stay on the anchor tag after updating.

Environment (please complete the following information):

  • @vendure/core version: 2.0.2
  • Nodejs version 16
  • Database (mysql/postgres etc): mysql

Additional context
image

@michaelbromley
Copy link
Member

I went one better and added a UI control for the target 😉
image

@martijnvdbrug
Copy link
Collaborator Author

Ohh sweet! Thats nice 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants