Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2.0.0-beta2][core] two identical history records after adding payment #2204

Open
alexgoncharcherkassy opened this issue May 31, 2023 · 1 comment
Open

[v2.0.0-beta2][core] two identical history records after adding payment #2204

alexgoncharcherkassy opened this issue May 31, 2023 · 1 comment
Assignees
@michaelbromley
Labels
type: bug 🐛 Something isn't working

Comments

@alexgoncharcherkassy
Copy link

Describe the bug
After adding payment to order on Admin UI, i see 2 identical history records
jhbMIjN
Also i tried to debug this issue and found that onTransitionEnd (order-process) was fired twice

To Reproduce
Steps to reproduce the behavior:

  1. Prepare order
  2. Add payment

Expected behavior
i think, onTransitionEnd must fire once

Environment (please complete the following information):

  • @vendure/core version: 2.0.0-beta.2
  • Nodejs version: 16.20.0
  • Database (mysql/postgres etc): mysql

Additional context
@alexgoncharcherkassy alexgoncharcherkassy added the type: bug 🐛 Something isn't working label May 31, 2023
@alexgoncharcherkassy alexgoncharcherkassy changed the title [v2.0.0-beta2][core] [v2.0.0-beta2][core] two identical history records after adding payment May 31, 2023
@alexgoncharcherkassy
Copy link
Author

i found possible reason, we have transitionToState to "PaymentSettled" state in default payment process, but at the same moment Admin UI send request TransitionOrderToState with 'PaymentSettled' state

michaelbromley added a commit that referenced this issue Jun 12, 2023
@michaelbromley
fix(core): Fix order state change from default payment process
0e5129e 
Relates to #2204
michaelbromley added a commit that referenced this issue Jun 12, 2023
@michaelbromley
fix(admin-ui): Prevent duplicate order state change on manual payment
eadc479 
Relates to #2204
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelbromley michaelbromley

Labels
type: bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelbromley @alexgoncharcherkassy