Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slide of image in the admin-ui panel #2129

Closed
giosueDelgado opened this issue Apr 18, 2023 · 8 comments
Closed

Add slide of image in the admin-ui panel #2129

giosueDelgado opened this issue Apr 18, 2023 · 8 comments

Comments

@giosueDelgado
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

We want to add a "<" and ">" when an image is opened in the admin-ui product page.

For example:

image

Describe the solution you'd like

When click on < or > go in the next or previus image of the product.
This also for product and variant.

@michaelbromley
Copy link
Member

This is a good suggestion! I will see if I have time to work this into the Admin UI refresh I am doing for v2.

@Mizan3050
Copy link
Contributor

Mizan3050 commented Apr 21, 2023

@michaelbromley I can do this, let me know if there is any library that I can use to implement slide. Or is there anything existing component being used for slide.

@giosueDelgado
Copy link
Collaborator Author

Hi guys, can we give more attention to this point?

@giosueDelgado
Copy link
Collaborator Author

I see that clarity design not have a slider but maybe @michaelbromley do some component in other section that we can use.

@michaelbromley
Copy link
Member

Hi, sorry for the lack of reply on this. I didn't get time to implement myself and no, there is no existing ui component which already does this. It would need to be created.

If we do this, it makes sense to generalize the solution to any place where we have a number of assets which can be opened in the dialog. So:

  • product detail view
  • product variant detail view
  • collection detail view
  • asset list view

This would involve modifying the AssetPreviewDialogComponent to allow it to take an array of assets.

@Mizan3050 let me know if you are still interested in having a go at this, or anyone else for that matter.

@Mizan3050
Copy link
Contributor

Yes, I can work on this.

@giosueDelgado
Copy link
Collaborator Author

Cool! @Mizan3050 Thanks for your support!!

@Mizan3050
Copy link
Contributor

@michaelbromley Hii, sorry for the delay. I have raised a PR for this feature. Please review it and let me know if I can improve it.

michaelbromley pushed a commit that referenced this issue Sep 12, 2023
@michaelbromley michaelbromley moved this from 📅 Planned to ✅ Done in Vendure OS Roadmap Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🚀 Shipped
Development

No branches or pull requests

3 participants