-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Active order returns null when combined with other queries #2097
Comments
Hey @michaelbromley, could I be assigned to this issue? |
I spent some time investigating this issue (I even live streamed the debugging session here https://www.youtube.com/live/f0srTEUqr5Y?si=VQT78GlA7KXXQ60U&t=361) The root cause is that the AuthGuard.canActivate executes for both resolvers, For any given query field there are 3 relevant steps as relates to this issue:
Step 3 is where the bug arises. There are 2 possible sequences, and which one occurs is non-deterministic: happy path
error path
I am currently exploring alternative approaches to how we store the RequestContext and make it available to resolvers & controller methods. |
Thank you, Michael! |
Describe the bug
When requesting multiple queries from the server, one of which is the
activeOrder
, the active order returnsnull
.To Reproduce
Steps to reproduce the behavior:
Expected behavior
Active order not to be null.
Environment (please complete the following information):
Additional context
If you remove the
activeChannel
query, the active order gets returned properly.The text was updated successfully, but these errors were encountered: