fix(admin-ui): Fix error when saving multiple new variant options

Fixes #2326
vendure-ecommerce · Aug 11, 2023 · e5ad0ee · e5ad0ee
1 parent ada153e
commit e5ad0ee
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/...c/lib/catalog/src/components/product-variants-editor/product-variants-editor.component.ts b/...c/lib/catalog/src/components/product-variants-editor/product-variants-editor.component.ts
@@ -15,6 +15,7 @@ import {
     SelectionManager,
 } from '@vendure/admin-ui/core';
 import { normalizeString } from '@vendure/common/lib/normalize-string';
+import { unique } from '@vendure/common/lib/unique';
 import { EMPTY, Observable, Subject } from 'rxjs';
 import { map, startWith, switchMap } from 'rxjs/operators';
 
@@ -296,14 +297,15 @@ export class ProductVariantsEditorComponent implements OnInit, DeactivateAware {
     }
 
     addOptionToVariant(variant: NonNullable<GetProductVariantOptionsQuery['product']>['variants'][number]) {
+        const optionIds = [
+            ...variant.options.map(o => o.id),
+            ...Object.values(this.optionsToAddToVariant[variant.id]),
+        ];
         this.dataService.product
             .updateProductVariants([
                 {
                     id: variant.id,
-                    optionIds: [
-                        ...variant.options.map(o => o.id),
-                        ...Object.values(this.optionsToAddToVariant[variant.id]),
-                    ],
+                    optionIds: unique(optionIds),
                 },
             ])
             .subscribe(({ updateProductVariants }) => {