Skip to content

Commit e5ad0ee

Browse files
fix(admin-ui): Fix error when saving multiple new variant options
Fixes #2326
1 parent ada153e commit e5ad0ee

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

packages/admin-ui/src/lib/catalog/src/components/product-variants-editor/product-variants-editor.component.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import {
1515
SelectionManager,
1616
} from '@vendure/admin-ui/core';
1717
import { normalizeString } from '@vendure/common/lib/normalize-string';
18+
import { unique } from '@vendure/common/lib/unique';
1819
import { EMPTY, Observable, Subject } from 'rxjs';
1920
import { map, startWith, switchMap } from 'rxjs/operators';
2021

@@ -296,14 +297,15 @@ export class ProductVariantsEditorComponent implements OnInit, DeactivateAware {
296297
}
297298

298299
addOptionToVariant(variant: NonNullable<GetProductVariantOptionsQuery['product']>['variants'][number]) {
300+
const optionIds = [
301+
...variant.options.map(o => o.id),
302+
...Object.values(this.optionsToAddToVariant[variant.id]),
303+
];
299304
this.dataService.product
300305
.updateProductVariants([
301306
{
302307
id: variant.id,
303-
optionIds: [
304-
...variant.options.map(o => o.id),
305-
...Object.values(this.optionsToAddToVariant[variant.id]),
306-
],
308+
optionIds: unique(optionIds),
307309
},
308310
])
309311
.subscribe(({ updateProductVariants }) => {

0 commit comments

Comments
 (0)