fix(core): Replace insecure randomness with secure randomBytes

vendure-ecommerce · Sep 18, 2024 · cb556d8 · cb556d8
1 parent 2a817cb
commit cb556d8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/packages/core/src/config/default-config.ts b/packages/core/src/config/default-config.ts
@@ -5,6 +5,7 @@ import {
     SUPER_ADMIN_USER_PASSWORD,
     DEFAULT_CHANNEL_TOKEN_KEY,
 } from '@vendure/common/lib/shared-constants';
+import { randomBytes } from 'crypto';
 
 import { TypeORMHealthCheckStrategy } from '../health-check/typeorm-health-check-strategy';
 import { InMemoryJobQueueStrategy } from '../job-queue/in-memory-job-queue-strategy';
@@ -89,7 +90,7 @@ export const defaultConfig: RuntimeVendureConfig = {
         disableAuth: false,
         tokenMethod: 'cookie',
         cookieOptions: {
-            secret: Math.random().toString(36).substr(3),
+            secret: randomBytes(16).toString('base64url'),
             httpOnly: true,
             sameSite: 'lax',
         },

diff --git a/packages/create/src/gather-user-responses.ts b/packages/create/src/gather-user-responses.ts
@@ -1,5 +1,6 @@
-import { cancel, intro, isCancel, outro, select, text } from '@clack/prompts';
+import { cancel, isCancel, select, text } from '@clack/prompts';
 import { SUPER_ADMIN_USER_IDENTIFIER, SUPER_ADMIN_USER_PASSWORD } from '@vendure/common/lib/shared-constants';
+import { randomBytes } from 'crypto';
 import fs from 'fs-extra';
 import Handlebars from 'handlebars';
 import path from 'path';
@@ -205,7 +206,7 @@ async function generateSources(
         isSQLite: answers.dbType === 'sqlite',
         isSQLjs: answers.dbType === 'sqljs',
         requiresConnection: answers.dbType !== 'sqlite' && answers.dbType !== 'sqljs',
-        cookieSecret: Math.random().toString(36).substr(2),
+        cookieSecret: randomBytes(16).toString('base64url'),
     };
 
     async function createSourceFile(filename: string, noEscape = false): Promise<string> {