fix(core): Fix typing on ProductOptionGroupService.create() method

Relates to #2577
vendure-ecommerce · Feb 26, 2024 · 8fe24da · 8fe24da
1 parent d8648ac
commit 8fe24da
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/packages/core/src/config/entity/entity-duplicators/product-duplicator.ts b/packages/core/src/config/entity/entity-duplicators/product-duplicator.ts
@@ -114,7 +114,6 @@ export const productDuplicator = new EntityDuplicator({
                                 customFields: translation.customFields,
                             };
                         }),
-                        options: [],
                     });
                     const options: CreateProductOptionInput[] = optionGroup.options.map(option => {
                         return {

diff --git a/packages/core/src/event-bus/events/product-option-group-event.ts b/packages/core/src/event-bus/events/product-option-group-event.ts
@@ -8,7 +8,10 @@ import { RequestContext } from '../../api/common/request-context';
 import { ProductOptionGroup } from '../../entity';
 import { VendureEntityEvent } from '../vendure-entity-event';
 
-type ProductOptionGroupInputTypes = CreateProductOptionGroupInput | UpdateProductOptionGroupInput | ID;
+type ProductOptionGroupInputTypes =
+    | Omit<CreateProductOptionGroupInput, 'options'>
+    | UpdateProductOptionGroupInput
+    | ID;
 
 /**
  * @description

diff --git a/packages/core/src/service/services/product-option-group.service.ts b/packages/core/src/service/services/product-option-group.service.ts
@@ -92,7 +92,7 @@ export class ProductOptionGroupService {
 
     async create(
         ctx: RequestContext,
-        input: CreateProductOptionGroupInput,
+        input: Omit<CreateProductOptionGroupInput, 'options'>,
     ): Promise<Translated<ProductOptionGroup>> {
         const group = await this.translatableSaver.create({
             ctx,