fix(core): Do not publish CollectionModificationEvent if no changes

Relates to vendure-ecommerce/vendure-plus-issues#25
vendure-ecommerce · Jul 27, 2023 · 75f6dec · 75f6dec
1 parent 7c9d110
commit 75f6dec
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/packages/core/src/service/services/collection.service.ts b/packages/core/src/service/services/collection.service.ts
@@ -48,7 +48,6 @@ import { moveToIndex } from '../helpers/utils/move-to-index';
 
 import { AssetService } from './asset.service';
 import { ChannelService } from './channel.service';
-import { FacetValueService } from './facet-value.service';
 import { RoleService } from './role.service';
 
 export type ApplyCollectionFiltersJobData = {
@@ -72,7 +71,6 @@ export class CollectionService implements OnModuleInit {
         private connection: TransactionalConnection,
         private channelService: ChannelService,
         private assetService: AssetService,
-        private facetValueService: FacetValueService,
         private listQueryBuilder: ListQueryBuilder,
         private translatableSaver: TranslatableSaver,
         private eventBus: EventBus,
@@ -142,9 +140,11 @@ export class CollectionService implements OnModuleInit {
                             continue;
                         }
                         job.setProgress(Math.ceil((completed / job.data.collectionIds.length) * 100));
-                        this.eventBus.publish(
-                            new CollectionModificationEvent(ctx, collection, affectedVariantIds),
-                        );
+                        if (affectedVariantIds.length) {
+                            this.eventBus.publish(
+                                new CollectionModificationEvent(ctx, collection, affectedVariantIds),
+                            );
+                        }
                     }
                 }
             },