fix(core): Fix deleted product option groups can't be deleted again (#…

…2706)
vendure-ecommerce · Apr 3, 2024 · 16add4a · 16add4a
1 parent 969b72c
commit 16add4a
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/packages/core/src/service/services/product.service.ts b/packages/core/src/service/services/product.service.ts
@@ -289,14 +289,16 @@ export class ProductService {
             return variantResult;
         }
         for (const optionGroup of product.optionGroups) {
-            const groupResult = await this.productOptionGroupService.deleteGroupAndOptionsFromProduct(
-                ctx,
-                optionGroup.id,
-                productId,
-            );
-            if (groupResult.result === DeletionResult.NOT_DELETED) {
-                await this.connection.rollBackTransaction(ctx);
-                return groupResult;
+            if (!optionGroup.deletedAt) {
+                const groupResult = await this.productOptionGroupService.deleteGroupAndOptionsFromProduct(
+                    ctx,
+                    optionGroup.id,
+                    productId,
+                );
+                if (groupResult.result === DeletionResult.NOT_DELETED) {
+                    await this.connection.rollBackTransaction(ctx);
+                    return groupResult;
+                }
             }
         }
         return {