Type Errors in node_modules/koa-helmet/node_modules/helmet/dist/types/index

[zvaehn]

It seems that there are some type errors in the "koa-helmet.d.ts" file.

Package Version: 7.0.1
Node Version: v16.14.0
Npm Version: 9.1.1

  scriptSrcAttr?: KoahelmetCspDirectiveValue[];

should be written with a capital "H" -> KoaHelmetCspDirectiveValue

[gpinto67]

options types are resolving to never for all options, despite the fact that headers like hsts and other should take options for configuration.

[jraoult]

There are other issues with the definition file when using moduleResolution with NodeNext or Node16 although they are not relevant for this issue. The main issue is in koa-helmet.d.ts that somehow the following is not working anymore:

type HelmetOptions = Required<Parameters<typeof helmet>>[0];

and we can use instead:

type HelmetOptions = Required<Parameters<typeof helmet.default>>[0];

or even simpler:

type HelmetOptions = helmet.HelmetOptions;

and yeah, of course, there is also the case issue mentioned by @zvaehn for the particular case of scriptSrcAttr.

[julienw]

I believe that last issue is what gives the error is not assignable to undefined.
It would be good to fix this. Anyone want to do a PR about this?

[heunghingwan]

done. #87

[venables]

Sorry about this! Fixed in #87 and released in version 7.0.2